Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/omap: fix OMAP4 hdmi_core_powerdown_disable()

hdmi_core_powerdown_disable() is supposed to disable HDMI core's
power-down mode. However, the function sets the power-down bit to 0,
which means "enable power-down".

This hasn't caused any issues as the PD seems to affect only interrupts
from HDMI core, and none of those interrupts are used at the moment. CEC
functionality requires core interrupts, and the PD mode needs to be
fixed.

This patch fixes hdmi_core_powerdown_disable() to actually disable the
PD mode.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>

+1 -1
+1 -1
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c
··· 211 211 static void hdmi_core_powerdown_disable(struct hdmi_core_data *core) 212 212 { 213 213 DSSDBG("Enter hdmi_core_powerdown_disable\n"); 214 - REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x0, 0, 0); 214 + REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x1, 0, 0); 215 215 } 216 216 217 217 static void hdmi_core_swreset_release(struct hdmi_core_data *core)