Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: cpcihp: Remove unused .get_power() and .set_power()

The .get_power() and .set_power() function pointers in struct
cpci_hp_controller_ops were declared but never implemented by any
driver.

Thus, to improve code readability and reduce resource usage,
remove these pointers and the code that has never been used.

Link: https://lore.kernel.org/r/20250217185638.398925-1-trintaeoitogc@gmail.com
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

authored by

Guilherme Giacomo Simoes and committed by
Krzysztof Wilczyński
8ff4574c 588021b2

+2 -17
-2
drivers/pci/hotplug/cpci_hotplug.h
··· 44 44 int (*enable_irq)(void); 45 45 int (*disable_irq)(void); 46 46 int (*check_irq)(void *dev_id); 47 - u8 (*get_power)(struct slot *slot); 48 - int (*set_power)(struct slot *slot, int value); 49 47 }; 50 48 51 49 struct cpci_hp_controller {
+2 -15
drivers/pci/hotplug/cpci_hotplug_core.c
··· 71 71 enable_slot(struct hotplug_slot *hotplug_slot) 72 72 { 73 73 struct slot *slot = to_slot(hotplug_slot); 74 - int retval = 0; 75 74 76 75 dbg("%s - physical_slot = %s", __func__, slot_name(slot)); 77 76 78 - if (controller->ops->set_power) 79 - retval = controller->ops->set_power(slot, 1); 80 - return retval; 77 + return 0; 81 78 } 82 79 83 80 static int ··· 106 109 } 107 110 cpci_led_on(slot); 108 111 109 - if (controller->ops->set_power) { 110 - retval = controller->ops->set_power(slot, 0); 111 - if (retval) 112 - goto disable_error; 113 - } 114 - 115 112 slot->adapter_status = 0; 116 113 117 114 if (slot->extracting) { ··· 120 129 static u8 121 130 cpci_get_power_status(struct slot *slot) 122 131 { 123 - u8 power = 1; 124 - 125 - if (controller->ops->get_power) 126 - power = controller->ops->get_power(slot); 127 - return power; 132 + return 1; 128 133 } 129 134 130 135 static int