Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

EDAC, qcom_edac: Remove irq_handled local variable

irq_handled isn't initialized to false on function entry. However, it is
not really needed and the IRQ handler return value can be set directly
instead.

[ bp: rewrite commit message. ]

Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
CC: Channagoud Kadabi <ckadabi@codeaurora.org>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
CC: kernel-janitors@vger.kernel.org
CC: linux-arm-msm@vger.kernel.org
CC: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20181018141522.rywdvjmlpk4ticiw@kili.mountain

authored by

Dan Carpenter and committed by
Borislav Petkov
8fd8cbfe 1a81361f

+2 -6
+2 -6
drivers/edac/qcom_edac.c
··· 292 292 struct llcc_drv_data *drv = edac_dev_ctl->pvt_info; 293 293 irqreturn_t irq_rc = IRQ_NONE; 294 294 u32 drp_error, trp_error, i; 295 - bool irq_handled; 296 295 int ret; 297 296 298 297 /* Iterate over the banks and look for Tag RAM or Data RAM errors */ ··· 310 311 ret = dump_syn_reg(edev_ctl, LLCC_DRAM_UE, i); 311 312 } 312 313 if (!ret) 313 - irq_handled = true; 314 + irq_rc = IRQ_HANDLED; 314 315 315 316 ret = regmap_read(drv->regmap, 316 317 drv->offsets[i] + TRP_INTERRUPT_0_STATUS, ··· 326 327 ret = dump_syn_reg(edev_ctl, LLCC_TRAM_UE, i); 327 328 } 328 329 if (!ret) 329 - irq_handled = true; 330 + irq_rc = IRQ_HANDLED; 330 331 } 331 - 332 - if (irq_handled) 333 - irq_rc = IRQ_HANDLED; 334 332 335 333 return irq_rc; 336 334 }