Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that I replaced "Fall through !!!" with a "fall through"
annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114971 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

+3 -3
+3 -3
drivers/scsi/bfa/bfa_fcpim.c
··· 2586 2586 case FCP_IODIR_RW: 2587 2587 bfa_stats(itnim, input_reqs); 2588 2588 bfa_stats(itnim, output_reqs); 2589 + /* fall through */ 2589 2590 default: 2590 2591 bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa)); 2591 2592 } ··· 2821 2820 2822 2821 case BFI_IOIM_STS_TIMEDOUT: 2823 2822 bfa_stats(ioim->itnim, iocomp_timedout); 2823 + /* fall through */ 2824 2824 case BFI_IOIM_STS_ABORTED: 2825 2825 rsp->io_status = BFI_IOIM_STS_ABORTED; 2826 2826 bfa_stats(ioim->itnim, iocomp_aborted); ··· 3217 3215 switch (event) { 3218 3216 case BFA_TSKIM_SM_DONE: 3219 3217 bfa_reqq_wcancel(&tskim->reqq_wait); 3220 - /* 3221 - * Fall through !!! 3222 - */ 3218 + /* fall through */ 3223 3219 case BFA_TSKIM_SM_QRESUME: 3224 3220 bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup); 3225 3221 bfa_tskim_send_abort(tskim);