Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: comedi vmk80xx: lock held on error path

If the user passes an invalid command, then we don't drop the lock
before returning. The check for invalid commands doesn't need to be
done under lock so I moved it forward a couple lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Dan Carpenter and committed by
Greg Kroah-Hartman
8f9064a8 3fb95e56

+2 -2
+2 -2
drivers/staging/comedi/drivers/vmk80xx.c
··· 1020 1020 if (n) 1021 1021 return n; 1022 1022 1023 - down(&dev->limit_sem); 1024 - 1025 1023 insn_cmd = data[0]; 1026 1024 if (insn_cmd != INSN_CONFIG_RESET && insn_cmd != GPCT_RESET) 1027 1025 return -EINVAL; 1026 + 1027 + down(&dev->limit_sem); 1028 1028 1029 1029 chan = CR_CHAN(insn->chanspec); 1030 1030