Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration

As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

Simplify code and remove some dead code accordingly.

[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Christophe JAILLET and committed by
Vinod Koul
8f7cc637 386fe06c

+1 -3
+1 -3
drivers/dma/qcom/hidma.c
··· 838 838 rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); 839 839 if (rc) { 840 840 dev_warn(&pdev->dev, "unable to set coherent mask to 64"); 841 - rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); 842 - if (rc) 843 - goto dmafree; 841 + goto dmafree; 844 842 } 845 843 846 844 dmadev->lldev = hidma_ll_init(dmadev->ddev.dev,