Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Staging: drop redundant memset

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Julia Lawall and committed by
Greg Kroah-Hartman
8f18604e 347fd7db

-8
-1
drivers/staging/rt2860/sta/assoc.c
··· 1596 1596 union iwreq_data wrqu; 1597 1597 wext_notify_event_assoc(pAd); 1598 1598 1599 - memset(wrqu.ap_addr.sa_data, 0, MAC_ADDR_LEN); 1600 1599 memcpy(wrqu.ap_addr.sa_data, pAd->MlmeAux.Bssid, MAC_ADDR_LEN); 1601 1600 wireless_send_event(pAd->net_dev, SIOCGIWAP, &wrqu, NULL); 1602 1601
-1
drivers/staging/rt2860/sta_ioctl.c
··· 608 608 /* Prevent to connect AP again in STAMlmePeriodicExec */ 609 609 pAdapter->MlmeAux.AutoReconnectSsidLen = 32; 610 610 611 - memset(Bssid, 0, MAC_ADDR_LEN); 612 611 memcpy(Bssid, ap_addr->sa_data, MAC_ADDR_LEN); 613 612 MlmeEnqueue(pAdapter, 614 613 MLME_CNTL_STATE_MACHINE,
-1
drivers/staging/rtl8192su/r819xU_cmdpkt.c
··· 33 33 tcb_desc->bLastIniPkt = 0; 34 34 skb_reserve(skb, USB_HWDESC_HEADER_LEN); 35 35 ptr_buf = skb_put(skb, DataLen); 36 - memset(ptr_buf, 0, DataLen); 37 36 memcpy(ptr_buf, pData, DataLen); 38 37 tcb_desc->txbuf_size = (u16)DataLen; 39 38
-1
drivers/staging/rtl8192u/r819xU_cmdpkt.c
··· 63 63 tcb_desc->bLastIniPkt = 0; 64 64 skb_reserve(skb, USB_HWDESC_HEADER_LEN); 65 65 ptr_buf = skb_put(skb, DataLen); 66 - memset(ptr_buf,0,DataLen); 67 66 memcpy(ptr_buf,pData,DataLen); 68 67 tcb_desc->txbuf_size= (u16)DataLen; 69 68
-2
drivers/staging/vt6655/iwctl.c
··· 699 699 if (wrq->sa_family != ARPHRD_ETHER) 700 700 rc = -EINVAL; 701 701 else { 702 - memset(pMgmt->abyDesireBSSID, 0xFF, 6); 703 702 memcpy(pMgmt->abyDesireBSSID, wrq->sa_data, 6); 704 703 //2008-0409-05, <Add> by Einsn Liu 705 704 if((pDevice->bLinkPass == TRUE) && ··· 888 889 BYTE abyTmpDesireSSID[WLAN_IEHDR_LEN + WLAN_SSID_MAXLEN + 1]; 889 890 UINT ii , uSameBssidNum=0; 890 891 891 - memset(abyTmpDesireSSID,0,sizeof(abyTmpDesireSSID)); 892 892 memcpy(abyTmpDesireSSID,pMgmt->abyDesireSSID,sizeof(abyTmpDesireSSID)); 893 893 pCurr = BSSpSearchBSSList(pDevice, 894 894 NULL,
-2
drivers/staging/vt6656/iwctl.c
··· 758 758 if (wrq->sa_family != ARPHRD_ETHER) 759 759 rc = -EINVAL; 760 760 else { 761 - memset(pMgmt->abyDesireBSSID, 0xFF, 6); 762 761 memcpy(pMgmt->abyDesireBSSID, wrq->sa_data, 6); 763 762 764 763 //mike :add ··· 935 936 BYTE abyTmpDesireSSID[WLAN_IEHDR_LEN + WLAN_SSID_MAXLEN + 1]; 936 937 UINT ii , uSameBssidNum=0; 937 938 938 - memset(abyTmpDesireSSID,0,sizeof(abyTmpDesireSSID)); 939 939 memcpy(abyTmpDesireSSID,pMgmt->abyDesireSSID,sizeof(abyTmpDesireSSID)); 940 940 pCurr = BSSpSearchBSSList(pDevice, 941 941 NULL,