Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

epic100: fix use after free on rmmod

epic_close() calls epic_rx() and uses dma buffer, but in epic_remove_one()
we already freed the dma buffer. To fix this issue, reorder function calls
like in the .probe function.

BUG: KASAN: use-after-free in epic_rx+0xa6/0x7e0 [epic100]
Call Trace:
epic_rx+0xa6/0x7e0 [epic100]
epic_close+0xec/0x2f0 [epic100]
unregister_netdev+0x18/0x20
epic_remove_one+0xaa/0xf0 [epic100]

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Yilun Wu <yiluwu@cs.stonybrook.edu>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Reviewed-by: Francois Romieu <romieu@fr.zoreil.com>
Link: https://lore.kernel.org/r/20220627043351.25615-1-ztong0001@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Tong Zhang and committed by
Jakub Kicinski
8ee9d82c a8fc8cb5

+2 -2
+2 -2
drivers/net/ethernet/smsc/epic100.c
··· 1515 1515 struct net_device *dev = pci_get_drvdata(pdev); 1516 1516 struct epic_private *ep = netdev_priv(dev); 1517 1517 1518 + unregister_netdev(dev); 1518 1519 dma_free_coherent(&pdev->dev, TX_TOTAL_SIZE, ep->tx_ring, 1519 1520 ep->tx_ring_dma); 1520 1521 dma_free_coherent(&pdev->dev, RX_TOTAL_SIZE, ep->rx_ring, 1521 1522 ep->rx_ring_dma); 1522 - unregister_netdev(dev); 1523 1523 pci_iounmap(pdev, ep->ioaddr); 1524 - pci_release_regions(pdev); 1525 1524 free_netdev(dev); 1525 + pci_release_regions(pdev); 1526 1526 pci_disable_device(pdev); 1527 1527 /* pci_power_off(pdev, -1); */ 1528 1528 }