Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PM / devfreq: rk3399_dmc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

authored by

Uwe Kleine-König and committed by
Chanwoo Choi
8eba5b69 14532a01

+2 -4
+2 -4
drivers/devfreq/rk3399_dmc.c
··· 459 459 return ret; 460 460 } 461 461 462 - static int rk3399_dmcfreq_remove(struct platform_device *pdev) 462 + static void rk3399_dmcfreq_remove(struct platform_device *pdev) 463 463 { 464 464 struct rk3399_dmcfreq *dmcfreq = dev_get_drvdata(&pdev->dev); 465 465 466 466 devfreq_event_disable_edev(dmcfreq->edev); 467 - 468 - return 0; 469 467 } 470 468 471 469 static const struct of_device_id rk3399dmc_devfreq_of_match[] = { ··· 474 476 475 477 static struct platform_driver rk3399_dmcfreq_driver = { 476 478 .probe = rk3399_dmcfreq_probe, 477 - .remove = rk3399_dmcfreq_remove, 479 + .remove_new = rk3399_dmcfreq_remove, 478 480 .driver = { 479 481 .name = "rk3399-dmc-freq", 480 482 .pm = &rk3399_dmcfreq_pm,