Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'phy-fixes2-5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy into char-misc-next

Vinod writes:

phy: second round of phy fixes for v5.11

- rockchip: init return and vednor prefix to dt-property
- cpcap: bool conversion fix
- lantiq: clock enable fix
- lgm: kconfig depends on x86
- mediatek: add mising MODULE_DEVICE_TABLE()

* tag 'phy-fixes2-5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy:
phy: mediatek: Add missing MODULE_DEVICE_TABLE()
phy: phy-brcm-sata: remove unneeded semicolon
phy: USB_LGM_PHY should depend on X86
phy: lantiq: rcu-usb2: wait after clock enable
phy: rockchip: emmc, add vendor prefix to dts properties
devicetree: phy: rockchip-emmc optional add vendor prefix
phy: cpcap-usb: remove unneeded conversion to bool
phy: rockchip-emmc: emmc_phy_init() always return 0

+25 -12
+5 -5
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
··· 16 16 - drive-impedance-ohm: Specifies the drive impedance in Ohm. 17 17 Possible values are 33, 40, 50, 66 and 100. 18 18 If not set, the default value of 50 will be applied. 19 - - enable-strobe-pulldown: Enable internal pull-down for the strobe line. 20 - If not set, pull-down is not used. 21 - - output-tapdelay-select: Specifies the phyctrl_otapdlysec register. 22 - If not set, the register defaults to 0x4. 23 - Maximum value 0xf. 19 + - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe 20 + line. If not set, pull-down is not used. 21 + - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register. 22 + If not set, the register defaults to 0x4. 23 + Maximum value 0xf. 24 24 25 25 Example: 26 26
+1
drivers/phy/Kconfig
··· 52 52 config USB_LGM_PHY 53 53 tristate "INTEL Lightning Mountain USB PHY Driver" 54 54 depends on USB_SUPPORT 55 + depends on X86 || COMPILE_TEST 55 56 select USB_PHY 56 57 select REGULATOR 57 58 select REGULATOR_FIXED_VOLTAGE
+1 -1
drivers/phy/broadcom/phy-brcm-sata.c
··· 651 651 break; 652 652 msleep(20); 653 653 try--; 654 - }; 654 + } 655 655 656 656 if (!try) { 657 657 /* PLL did not lock; give up */
+9 -1
drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
··· 124 124 reset_control_deassert(priv->phy_reset); 125 125 126 126 ret = clk_prepare_enable(priv->phy_gate_clk); 127 - if (ret) 127 + if (ret) { 128 128 dev_err(dev, "failed to enable PHY gate\n"); 129 + return ret; 130 + } 131 + 132 + /* 133 + * at least the xrx200 usb2 phy requires some extra time to be 134 + * operational after enabling the clock 135 + */ 136 + usleep_range(100, 200); 129 137 130 138 return ret; 131 139 }
+1
drivers/phy/mediatek/phy-mtk-hdmi.c
··· 201 201 }, 202 202 {}, 203 203 }; 204 + MODULE_DEVICE_TABLE(of, mtk_hdmi_phy_match); 204 205 205 206 static struct platform_driver mtk_hdmi_phy_driver = { 206 207 .probe = mtk_hdmi_phy_probe,
+1
drivers/phy/mediatek/phy-mtk-mipi-dsi.c
··· 233 233 .data = &mt8183_mipitx_data }, 234 234 { }, 235 235 }; 236 + MODULE_DEVICE_TABLE(of, mtk_mipi_tx_match); 236 237 237 238 static struct platform_driver mtk_mipi_tx_driver = { 238 239 .probe = mtk_mipi_tx_probe,
+7 -5
drivers/phy/rockchip/phy-rockchip-emmc.c
··· 248 248 * - SDHCI driver to get the PHY 249 249 * - SDHCI driver to init the PHY 250 250 * 251 - * The clock is optional, so upon any error we just set to NULL. 251 + * The clock is optional, using clk_get_optional() to get the clock 252 + * and do error processing if the return value != NULL 252 253 * 253 254 * NOTE: we don't do anything special for EPROBE_DEFER here. Given the 254 255 * above expected use case, EPROBE_DEFER isn't sensible to expect, so 255 256 * it's just like any other error. 256 257 */ 257 - rk_phy->emmcclk = clk_get(&phy->dev, "emmcclk"); 258 + rk_phy->emmcclk = clk_get_optional(&phy->dev, "emmcclk"); 258 259 if (IS_ERR(rk_phy->emmcclk)) { 259 - dev_dbg(&phy->dev, "Error getting emmcclk: %d\n", ret); 260 + ret = PTR_ERR(rk_phy->emmcclk); 261 + dev_err(&phy->dev, "Error getting emmcclk: %d\n", ret); 260 262 rk_phy->emmcclk = NULL; 261 263 } 262 264 ··· 382 380 if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val)) 383 381 rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val); 384 382 385 - if (of_property_read_bool(dev->of_node, "enable-strobe-pulldown")) 383 + if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown")) 386 384 rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE; 387 385 388 - if (!of_property_read_u32(dev->of_node, "output-tapdelay-select", &val)) { 386 + if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select", &val)) { 389 387 if (val <= PHYCTRL_OTAPDLYSEL_MAXVALUE) 390 388 rk_phy->output_tapdelay_select = val; 391 389 else