Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
gpio: Fix sch_gpio warning
We need to check for gpiochip_remove() errors.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
+16
-3
drivers/gpio/sch_gpio.c
+16
-3
drivers/gpio/sch_gpio.c
···
229
return 0;
230
231
err_sch_gpio_resume:
232
-
gpiochip_remove(&sch_gpio_core);
233
234
err_sch_gpio_core:
235
release_region(res->start, resource_size(res));
···
245
{
246
struct resource *res;
247
if (gpio_ba) {
248
-
gpiochip_remove(&sch_gpio_core);
249
-
gpiochip_remove(&sch_gpio_resume);
250
251
res = platform_get_resource(pdev, IORESOURCE_IO, 0);
252
253
release_region(res->start, resource_size(res));
254
gpio_ba = 0;
255
}
256
257
return 0;
···
229
return 0;
230
231
err_sch_gpio_resume:
232
+
err = gpiochip_remove(&sch_gpio_core);
233
+
if (err)
234
+
dev_err(&pdev->dev, "%s failed, %d\n",
235
+
"gpiochip_remove()", err);
236
237
err_sch_gpio_core:
238
release_region(res->start, resource_size(res));
···
242
{
243
struct resource *res;
244
if (gpio_ba) {
245
+
int err;
246
+
247
+
err = gpiochip_remove(&sch_gpio_core);
248
+
if (err)
249
+
dev_err(&pdev->dev, "%s failed, %d\n",
250
+
"gpiochip_remove()", err);
251
+
err = gpiochip_remove(&sch_gpio_resume);
252
+
if (err)
253
+
dev_err(&pdev->dev, "%s failed, %d\n",
254
+
"gpiochip_remove()", err);
255
256
res = platform_get_resource(pdev, IORESOURCE_IO, 0);
257
258
release_region(res->start, resource_size(res));
259
gpio_ba = 0;
260
+
261
+
return err;
262
}
263
264
return 0;