Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: remove SOCK_DEBUG leftovers

SOCK_DEBUG comes from the old days. Let's
move logging to standard net core ratelimited logging functions

Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>

changes in v2:
- remove SOCK_DEBUG macro altogether

Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Denis Kirjanov and committed by
David S. Miller
8e5443d2 e3eb47f2

+24 -24
+8 -8
net/appletalk/ddp.c
··· 1581 1581 } 1582 1582 1583 1583 /* Build a packet */ 1584 - SOCK_DEBUG(sk, "SK %p: Got address.\n", sk); 1584 + net_dbg_ratelimited("SK %p: Got address.\n", sk); 1585 1585 1586 1586 /* For headers */ 1587 1587 size = sizeof(struct ddpehdr) + len + ddp_dl->header_length; ··· 1602 1602 1603 1603 dev = rt->dev; 1604 1604 1605 - SOCK_DEBUG(sk, "SK %p: Size needed %d, device %s\n", 1605 + net_dbg_ratelimited("SK %p: Size needed %d, device %s\n", 1606 1606 sk, size, dev->name); 1607 1607 1608 1608 hard_header_len = dev->hard_header_len; ··· 1631 1631 skb_reserve(skb, hard_header_len); 1632 1632 skb->dev = dev; 1633 1633 1634 - SOCK_DEBUG(sk, "SK %p: Begin build.\n", sk); 1634 + net_dbg_ratelimited("SK %p: Begin build.\n", sk); 1635 1635 1636 1636 ddp = skb_put(skb, sizeof(struct ddpehdr)); 1637 1637 ddp->deh_len_hops = htons(len + sizeof(*ddp)); ··· 1642 1642 ddp->deh_dport = usat->sat_port; 1643 1643 ddp->deh_sport = at->src_port; 1644 1644 1645 - SOCK_DEBUG(sk, "SK %p: Copy user data (%zd bytes).\n", sk, len); 1645 + net_dbg_ratelimited("SK %p: Copy user data (%zd bytes).\n", sk, len); 1646 1646 1647 1647 err = memcpy_from_msg(skb_put(skb, len), msg, len); 1648 1648 if (err) { ··· 1666 1666 1667 1667 if (skb2) { 1668 1668 loopback = 1; 1669 - SOCK_DEBUG(sk, "SK %p: send out(copy).\n", sk); 1669 + net_dbg_ratelimited("SK %p: send out(copy).\n", sk); 1670 1670 /* 1671 1671 * If it fails it is queued/sent above in the aarp queue 1672 1672 */ ··· 1675 1675 } 1676 1676 1677 1677 if (dev->flags & IFF_LOOPBACK || loopback) { 1678 - SOCK_DEBUG(sk, "SK %p: Loop back.\n", sk); 1678 + net_dbg_ratelimited("SK %p: Loop back.\n", sk); 1679 1679 /* loop back */ 1680 1680 skb_orphan(skb); 1681 1681 if (ddp->deh_dnode == ATADDR_BCAST) { ··· 1689 1689 } 1690 1690 ddp_dl->request(ddp_dl, skb, dev->dev_addr); 1691 1691 } else { 1692 - SOCK_DEBUG(sk, "SK %p: send out.\n", sk); 1692 + net_dbg_ratelimited("SK %p: send out.\n", sk); 1693 1693 if (rt->flags & RTF_GATEWAY) { 1694 1694 gsat.sat_addr = rt->gateway; 1695 1695 usat = &gsat; ··· 1700 1700 */ 1701 1701 aarp_send_ddp(dev, skb, &usat->sat_addr, NULL); 1702 1702 } 1703 - SOCK_DEBUG(sk, "SK %p: Done write (%zd).\n", sk, len); 1703 + net_dbg_ratelimited("SK %p: Done write (%zd).\n", sk, len); 1704 1704 1705 1705 out: 1706 1706 release_sock(sk);
+1 -1
net/dccp/ipv6.c
··· 889 889 u32 exthdrlen = icsk->icsk_ext_hdr_len; 890 890 struct sockaddr_in sin; 891 891 892 - SOCK_DEBUG(sk, "connect: ipv4 mapped\n"); 892 + net_dbg_ratelimited("connect: ipv4 mapped\n"); 893 893 894 894 if (ipv6_only_sock(sk)) 895 895 return -ENETUNREACH;
+7 -7
net/x25/af_x25.c
··· 704 704 rc = -EINVAL; 705 705 } 706 706 release_sock(sk); 707 - SOCK_DEBUG(sk, "x25_bind: socket is bound\n"); 707 + net_dbg_ratelimited("x25_bind: socket is bound\n"); 708 708 out: 709 709 return rc; 710 710 } ··· 1165 1165 goto out; 1166 1166 } 1167 1167 1168 - SOCK_DEBUG(sk, "x25_sendmsg: sendto: Addresses built.\n"); 1168 + net_dbg_ratelimited("x25_sendmsg: sendto: Addresses built.\n"); 1169 1169 1170 1170 /* Build a packet */ 1171 - SOCK_DEBUG(sk, "x25_sendmsg: sendto: building packet.\n"); 1171 + net_dbg_ratelimited("x25_sendmsg: sendto: building packet.\n"); 1172 1172 1173 1173 if ((msg->msg_flags & MSG_OOB) && len > 32) 1174 1174 len = 32; ··· 1187 1187 /* 1188 1188 * Put the data on the end 1189 1189 */ 1190 - SOCK_DEBUG(sk, "x25_sendmsg: Copying user data\n"); 1190 + net_dbg_ratelimited("x25_sendmsg: Copying user data\n"); 1191 1191 1192 1192 skb_reset_transport_header(skb); 1193 1193 skb_put(skb, len); ··· 1211 1211 /* 1212 1212 * Push down the X.25 header 1213 1213 */ 1214 - SOCK_DEBUG(sk, "x25_sendmsg: Building X.25 Header.\n"); 1214 + net_dbg_ratelimited("x25_sendmsg: Building X.25 Header.\n"); 1215 1215 1216 1216 if (msg->msg_flags & MSG_OOB) { 1217 1217 if (x25->neighbour->extended) { ··· 1245 1245 skb->data[0] |= X25_Q_BIT; 1246 1246 } 1247 1247 1248 - SOCK_DEBUG(sk, "x25_sendmsg: Built header.\n"); 1249 - SOCK_DEBUG(sk, "x25_sendmsg: Transmitting buffer\n"); 1248 + net_dbg_ratelimited("x25_sendmsg: Built header.\n"); 1249 + net_dbg_ratelimited("x25_sendmsg: Transmitting buffer\n"); 1250 1250 1251 1251 rc = -ENOTCONN; 1252 1252 if (sk->sk_state != TCP_ESTABLISHED)
+7 -7
net/x25/x25_facilities.c
··· 282 282 * They want reverse charging, we won't accept it. 283 283 */ 284 284 if ((theirs.reverse & 0x01 ) && (ours->reverse & 0x01)) { 285 - SOCK_DEBUG(sk, "X.25: rejecting reverse charging request\n"); 285 + net_dbg_ratelimited("X.25: rejecting reverse charging request\n"); 286 286 return -1; 287 287 } 288 288 ··· 294 294 int ours_in = ours->throughput & 0x0f; 295 295 int ours_out = ours->throughput & 0xf0; 296 296 if (!ours_in || theirs_in < ours_in) { 297 - SOCK_DEBUG(sk, "X.25: inbound throughput negotiated\n"); 297 + net_dbg_ratelimited("X.25: inbound throughput negotiated\n"); 298 298 new->throughput = (new->throughput & 0xf0) | theirs_in; 299 299 } 300 300 if (!ours_out || theirs_out < ours_out) { 301 - SOCK_DEBUG(sk, 301 + net_dbg_ratelimited( 302 302 "X.25: outbound throughput negotiated\n"); 303 303 new->throughput = (new->throughput & 0x0f) | theirs_out; 304 304 } ··· 306 306 307 307 if (theirs.pacsize_in && theirs.pacsize_out) { 308 308 if (theirs.pacsize_in < ours->pacsize_in) { 309 - SOCK_DEBUG(sk, "X.25: packet size inwards negotiated down\n"); 309 + net_dbg_ratelimited("X.25: packet size inwards negotiated down\n"); 310 310 new->pacsize_in = theirs.pacsize_in; 311 311 } 312 312 if (theirs.pacsize_out < ours->pacsize_out) { 313 - SOCK_DEBUG(sk, "X.25: packet size outwards negotiated down\n"); 313 + net_dbg_ratelimited("X.25: packet size outwards negotiated down\n"); 314 314 new->pacsize_out = theirs.pacsize_out; 315 315 } 316 316 } 317 317 318 318 if (theirs.winsize_in && theirs.winsize_out) { 319 319 if (theirs.winsize_in < ours->winsize_in) { 320 - SOCK_DEBUG(sk, "X.25: window size inwards negotiated down\n"); 320 + net_dbg_ratelimited("X.25: window size inwards negotiated down\n"); 321 321 new->winsize_in = theirs.winsize_in; 322 322 } 323 323 if (theirs.winsize_out < ours->winsize_out) { 324 - SOCK_DEBUG(sk, "X.25: window size outwards negotiated down\n"); 324 + net_dbg_ratelimited("X.25: window size outwards negotiated down\n"); 325 325 new->winsize_out = theirs.winsize_out; 326 326 } 327 327 }
+1 -1
net/x25/x25_out.c
··· 72 72 kfree_skb(skb); 73 73 return sent; 74 74 } 75 - SOCK_DEBUG(sk, "x25_output: fragment alloc" 75 + net_dbg_ratelimited("x25_output: fragment alloc" 76 76 " failed, err=%d, %d bytes " 77 77 "sent\n", err, sent); 78 78 return err;