Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c-powermac: Be less verbose in the absence of real errors.

Be less verbose in the absence of real errors. We don't have to report
failed probes to the users, it's only confusing them.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Andrey Gusev <ronne@list.ru>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: stable@kernel.org

+18 -7
+18 -7
drivers/i2c/busses/i2c-powermac.c
··· 122 122 123 123 rc = pmac_i2c_xfer(bus, addrdir, subsize, subaddr, buf, len); 124 124 if (rc) { 125 - dev_err(&adap->dev, 126 - "I2C transfer at 0x%02x failed, size %d, err %d\n", 127 - addrdir >> 1, size, rc); 125 + if (rc == -ENXIO) 126 + dev_dbg(&adap->dev, 127 + "I2C transfer at 0x%02x failed, size %d, " 128 + "err %d\n", addrdir >> 1, size, rc); 129 + else 130 + dev_err(&adap->dev, 131 + "I2C transfer at 0x%02x failed, size %d, " 132 + "err %d\n", addrdir >> 1, size, rc); 128 133 goto bail; 129 134 } 130 135 ··· 180 175 goto bail; 181 176 } 182 177 rc = pmac_i2c_xfer(bus, addrdir, 0, 0, msgs->buf, msgs->len); 183 - if (rc < 0) 184 - dev_err(&adap->dev, "I2C %s 0x%02x failed, err %d\n", 185 - addrdir & 1 ? "read from" : "write to", addrdir >> 1, 186 - rc); 178 + if (rc < 0) { 179 + if (rc == -ENXIO) 180 + dev_dbg(&adap->dev, "I2C %s 0x%02x failed, err %d\n", 181 + addrdir & 1 ? "read from" : "write to", 182 + addrdir >> 1, rc); 183 + else 184 + dev_err(&adap->dev, "I2C %s 0x%02x failed, err %d\n", 185 + addrdir & 1 ? "read from" : "write to", 186 + addrdir >> 1, rc); 187 + } 187 188 bail: 188 189 pmac_i2c_close(bus); 189 190 return rc < 0 ? rc : 1;