Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Add mask bit definition for MSI-X table

Then we can use it instead of magic number 1.

Reviewed-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

authored by

Sheng Yang and committed by
Jesse Barnes
8d805286 00aaaef9

+4 -2
+3 -2
drivers/pci/msi.c
··· 168 168 u32 mask_bits = desc->masked; 169 169 unsigned offset = desc->msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE + 170 170 PCI_MSIX_ENTRY_VECTOR_CTRL; 171 - mask_bits &= ~1; 172 - mask_bits |= flag; 171 + mask_bits &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT; 172 + if (flag) 173 + mask_bits |= PCI_MSIX_ENTRY_CTRL_MASKBIT; 173 174 writel(mask_bits, desc->mask_base + offset); 174 175 175 176 return mask_bits;
+1
include/linux/pci_regs.h
··· 315 315 #define PCI_MSIX_ENTRY_UPPER_ADDR 4 316 316 #define PCI_MSIX_ENTRY_DATA 8 317 317 #define PCI_MSIX_ENTRY_VECTOR_CTRL 12 318 + #define PCI_MSIX_ENTRY_CTRL_MASKBIT 1 318 319 319 320 /* CompactPCI Hotswap Register */ 320 321