Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: xgmiitorgmii: Check read_status results

We're ignoring the result of the attached phy device's read_status().
Return it so we can detect errors.

Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Brandon Maier and committed by
David S. Miller
8d0752d1 cf31ea71

+4 -1
+4 -1
drivers/net/phy/xilinx_gmii2rgmii.c
··· 42 42 struct mii_bus *bus = priv->mdio->bus; 43 43 int addr = priv->mdio->addr; 44 44 u16 val = 0; 45 + int err; 45 46 46 - priv->phy_drv->read_status(phydev); 47 + err = priv->phy_drv->read_status(phydev); 48 + if (err < 0) 49 + return err; 47 50 48 51 val = mdiobus_read(bus, addr, XILINX_GMII2RGMII_REG); 49 52 val &= ~XILINX_GMII2RGMII_SPEED_MASK;