Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: mc: Clear minor number before put device

The device minor should not be cleared after the device is released.

Fixes: 9e14868dc952 ("media: mc: Clear minor number reservation at unregistration time")
Cc: stable@vger.kernel.org
Reported-by: syzbot+031d0cfd7c362817963f@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=031d0cfd7c362817963f
Tested-by: syzbot+031d0cfd7c362817963f@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Edward Adam Davis and committed by
Hans Verkuil
8cfc8cec 895d3b4b

+1 -4
+1 -4
drivers/media/mc/mc-devnode.c
··· 276 276 /* Delete the cdev on this minor as well */ 277 277 cdev_device_del(&devnode->cdev, &devnode->dev); 278 278 devnode->media_dev = NULL; 279 + clear_bit(devnode->minor, media_devnode_nums); 279 280 mutex_unlock(&media_devnode_lock); 280 281 281 282 put_device(&devnode->dev); 282 - 283 - mutex_lock(&media_devnode_lock); 284 - clear_bit(devnode->minor, media_devnode_nums); 285 - mutex_unlock(&media_devnode_lock); 286 283 } 287 284 288 285 /*