Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/powernv: Fix memtrace build when NUMA=n

Currently memtrace doesn't build if NUMA=n:

In function ‘memtrace_alloc_node’:
arch/powerpc/platforms/powernv/memtrace.c:134:6:
error: the address of ‘contig_page_data’ will always evaluate as ‘true’
if (!NODE_DATA(nid) || !node_spanned_pages(nid))
^

This is because for NUMA=n NODE_DATA(nid) points to an always
allocated structure, contig_page_data.

But even in the NUMA=y case memtrace_alloc_node() is only called for
online nodes, and we should always have a NODE_DATA() allocated for an
online node. So remove the (hopefully) overly paranoid check, which
also means we can build when NUMA=n.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

+1 -1
+1 -1
arch/powerpc/platforms/powernv/memtrace.c
··· 131 131 u64 start_pfn, end_pfn, nr_pages; 132 132 u64 base_pfn; 133 133 134 - if (!NODE_DATA(nid) || !node_spanned_pages(nid)) 134 + if (!node_spanned_pages(nid)) 135 135 return 0; 136 136 137 137 start_pfn = node_start_pfn(nid);