Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf kvm: Support using -f to override perf.data.guest file ownership

Enable perf kvm to use perf.data.guest when it is not owned by current
user or root.

Example:

# perf kvm stat record ls
# chown Yunlong.Song:Yunlong.Song perf.data.guest
# ls -al perf.data.guest
-rw------- 1 Yunlong.Song Yunlong.Song 4128937 Apr 2 11:05 perf.data.guest
# id
uid=0(root) gid=0(root) groups=0(root),64(pkcs11)

Before this patch:

# perf kvm stat report
File perf.data.guest not owned by current user or root (use -f to override)
Initializing perf session failed
# perf kvm stat report -f
Error: unknown switch `f'

usage: perf kvm stat report [<options>]

--event <report event>
event for reporting: vmexit, mmio (x86 only),
ioport (x86 only)
--vcpu <n> vcpu id to report
-k, --key <sort-key> key for sorting: sample(sort by samples
number) time (sort by avg time)
-p, --pid <pid> analyze events only for given process id(s)

As shown above, the -f option does not work at all.

After this patch:

# perf kvm stat report
File perf.data.guest not owned by current user or root (use -f to override)
Initializing perf session failed
# perf kvm stat report -f
Analyze events for all VMs, all VCPUs:

VM-EXIT Samples Samples% Time% Min Time Max Time Avg time

Total Samples:0, Total events handled time:0.00us.

As shown above, the -f option really works now. Since we have not
launched any KVM related process, the result shows 0 sample here.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1427982439-27388-5-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Yunlong Song and committed by
Arnaldo Carvalho de Melo
8cc5ec1f d1eeb77c

+3
+2
tools/perf/builtin-kvm.c
··· 1047 1047 struct perf_data_file file = { 1048 1048 .path = kvm->file_name, 1049 1049 .mode = PERF_DATA_MODE_READ, 1050 + .force = kvm->force, 1050 1051 }; 1051 1052 1052 1053 kvm->tool = eops; ··· 1205 1204 " time (sort by avg time)"), 1206 1205 OPT_STRING('p', "pid", &kvm->opts.target.pid, "pid", 1207 1206 "analyze events only for given process id(s)"), 1207 + OPT_BOOLEAN('f', "force", &kvm->force, "don't complain, do it"), 1208 1208 OPT_END() 1209 1209 }; 1210 1210
+1
tools/perf/util/kvm-stat.h
··· 99 99 int timerfd; 100 100 unsigned int display_time; 101 101 bool live; 102 + bool force; 102 103 }; 103 104 104 105 struct kvm_reg_events_ops {