Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

In case of memory allocation failure, a negative error code should
be returned.

Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Tianjia Zhang and committed by
Herbert Xu
8cbde6c6 e62291c1

+2 -2
+2 -2
drivers/crypto/mediatek/mtk-platform.c
··· 442 442 static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) 443 443 { 444 444 struct mtk_ring **ring = cryp->ring; 445 - int i, err = ENOMEM; 445 + int i; 446 446 447 447 for (i = 0; i < MTK_RING_MAX; i++) { 448 448 ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL); ··· 476 476 ring[i]->cmd_base, ring[i]->cmd_dma); 477 477 kfree(ring[i]); 478 478 } 479 - return err; 479 + return -ENOMEM; 480 480 } 481 481 482 482 static int mtk_crypto_probe(struct platform_device *pdev)