Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: rc: rename s_learning_mode() to s_wideband_receiver()

The s_learning_mode() function is called in response to the ioctl
LIRC_SET_WIDEBAND_RECEIVER, so rename it to s_wideband_receiver().

Learning mode is when both the wideband receiver is turned on and
carrier reports are enabled.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Sean Young and committed by
Mauro Carvalho Chehab
8b777edf 50634548

+22 -22
+1 -1
drivers/media/rc/ene_ir.c
··· 1052 1052 rdev->device_name = "ENE eHome Infrared Remote Receiver"; 1053 1053 1054 1054 if (dev->hw_learning_and_tx_capable) { 1055 - rdev->s_learning_mode = ene_set_learning_mode; 1055 + rdev->s_wideband_receiver = ene_set_learning_mode; 1056 1056 init_completion(&dev->tx_complete); 1057 1057 rdev->tx_ir = ene_transmit; 1058 1058 rdev->s_tx_mask = ene_set_tx_mask;
+3 -3
drivers/media/rc/lirc_dev.c
··· 412 412 val |= LIRC_CAN_SET_REC_CARRIER | 413 413 LIRC_CAN_SET_REC_CARRIER_RANGE; 414 414 415 - if (dev->s_learning_mode) 415 + if (dev->s_wideband_receiver) 416 416 val |= LIRC_CAN_USE_WIDEBAND_RECEIVER; 417 417 418 418 if (dev->s_carrier_report) ··· 519 519 break; 520 520 521 521 case LIRC_SET_WIDEBAND_RECEIVER: 522 - if (!dev->s_learning_mode) 522 + if (!dev->s_wideband_receiver) 523 523 ret = -ENOTTY; 524 524 else 525 - ret = dev->s_learning_mode(dev, !!val); 525 + ret = dev->s_wideband_receiver(dev, !!val); 526 526 break; 527 527 528 528 case LIRC_SET_MEASURE_CARRIER_MODE:
+1 -1
drivers/media/rc/mceusb.c
··· 1630 1630 rc->tx_ir = mceusb_tx_ir; 1631 1631 } 1632 1632 if (ir->flags.rx2 > 0) { 1633 - rc->s_learning_mode = mceusb_set_rx_wideband; 1633 + rc->s_wideband_receiver = mceusb_set_rx_wideband; 1634 1634 rc->s_carrier_report = mceusb_set_rx_carrier_report; 1635 1635 } 1636 1636 rc->driver_name = DRIVER_NAME;
+15 -15
drivers/media/rc/rc-loopback.c
··· 15 15 #include <linux/slab.h> 16 16 #include <media/rc-core.h> 17 17 18 - #define DRIVER_NAME "rc-loopback" 19 - #define RXMASK_REGULAR 0x1 20 - #define RXMASK_LEARNING 0x2 18 + #define DRIVER_NAME "rc-loopback" 19 + #define RXMASK_NARROWBAND 0x1 20 + #define RXMASK_WIDEBAND 0x2 21 21 22 22 struct loopback_dev { 23 23 struct rc_dev *dev; ··· 25 25 u32 txcarrier; 26 26 u32 txduty; 27 27 bool idle; 28 - bool learning; 28 + bool wideband; 29 29 bool carrierreport; 30 30 u32 rxcarriermin; 31 31 u32 rxcarriermax; ··· 37 37 { 38 38 struct loopback_dev *lodev = dev->priv; 39 39 40 - if ((mask & (RXMASK_REGULAR | RXMASK_LEARNING)) != mask) { 40 + if ((mask & (RXMASK_NARROWBAND | RXMASK_WIDEBAND)) != mask) { 41 41 dev_dbg(&dev->dev, "invalid tx mask: %u\n", mask); 42 42 return 2; 43 43 } ··· 98 98 goto out; 99 99 } 100 100 101 - if (lodev->learning) 102 - rxmask = RXMASK_LEARNING; 101 + if (lodev->wideband) 102 + rxmask = RXMASK_WIDEBAND; 103 103 else 104 - rxmask = RXMASK_REGULAR; 104 + rxmask = RXMASK_NARROWBAND; 105 105 106 106 if (!(rxmask & lodev->txmask)) { 107 107 dev_dbg(&dev->dev, "ignoring tx, rx mask mismatch\n"); ··· 144 144 } 145 145 } 146 146 147 - static int loop_set_learning_mode(struct rc_dev *dev, int enable) 147 + static int loop_set_wideband_receiver(struct rc_dev *dev, int enable) 148 148 { 149 149 struct loopback_dev *lodev = dev->priv; 150 150 151 - if (lodev->learning != enable) { 152 - dev_dbg(&dev->dev, "%sing learning mode\n", enable ? "enter" : "exit"); 153 - lodev->learning = !!enable; 151 + if (lodev->wideband != enable) { 152 + dev_dbg(&dev->dev, "using %sband receiver\n", enable ? "wide" : "narrow"); 153 + lodev->wideband = !!enable; 154 154 } 155 155 156 156 return 0; ··· 233 233 rc->s_rx_carrier_range = loop_set_rx_carrier_range; 234 234 rc->tx_ir = loop_tx_ir; 235 235 rc->s_idle = loop_set_idle; 236 - rc->s_learning_mode = loop_set_learning_mode; 236 + rc->s_wideband_receiver = loop_set_wideband_receiver; 237 237 rc->s_carrier_report = loop_set_carrier_report; 238 238 rc->s_wakeup_filter = loop_set_wakeup_filter; 239 239 240 - loopdev.txmask = RXMASK_REGULAR; 240 + loopdev.txmask = RXMASK_NARROWBAND; 241 241 loopdev.txcarrier = 36000; 242 242 loopdev.txduty = 50; 243 243 loopdev.rxcarriermin = 1; 244 244 loopdev.rxcarriermax = ~0; 245 245 loopdev.idle = true; 246 - loopdev.learning = false; 246 + loopdev.wideband = false; 247 247 loopdev.carrierreport = false; 248 248 249 249 ret = rc_register_device(rc);
+2 -2
include/media/rc-core.h
··· 151 151 * @tx_ir: transmit IR 152 152 * @s_idle: enable/disable hardware idle mode, upon which, 153 153 * device doesn't interrupt host until it sees IR pulses 154 - * @s_learning_mode: enable wide band receiver used for learning 154 + * @s_wideband_receiver: enable wide band receiver used for learning 155 155 * @s_carrier_report: enable carrier reports 156 156 * @s_filter: set the scancode filter 157 157 * @s_wakeup_filter: set the wakeup scancode filter. If the mask is zero ··· 218 218 int (*s_rx_carrier_range)(struct rc_dev *dev, u32 min, u32 max); 219 219 int (*tx_ir)(struct rc_dev *dev, unsigned *txbuf, unsigned n); 220 220 void (*s_idle)(struct rc_dev *dev, bool enable); 221 - int (*s_learning_mode)(struct rc_dev *dev, int enable); 221 + int (*s_wideband_receiver)(struct rc_dev *dev, int enable); 222 222 int (*s_carrier_report) (struct rc_dev *dev, int enable); 223 223 int (*s_filter)(struct rc_dev *dev, 224 224 struct rc_scancode_filter *filter);