Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: pxa2xxx: change "no DMA channels..." msg from debug to warning

Change the type of the diagnostic message:

"no DMA channels available, using PIO"

from debug to warning.

The lack of an available DMA channel is very important regard the
spi-pxa2xx performance. The transfer speed can be reduced more than 50%.

So it is very important to warn the user about this, without enabling
the full SPI debug with CONFIG_SPI_DEBUG.

Moreover, enabling the full SPI debug only to enable this specific
debug message, the dmesg buffer fills quickly with a lot of
repetitive information during the SPI data transfer.
This cause the loss of all the first important messages
written during the initialization.

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Flavio Suligoi and committed by
Mark Brown
8b57b11b 5d785141

+1 -1
+1 -1
drivers/spi/spi-pxa2xx.c
··· 1696 1696 if (platform_info->enable_dma) { 1697 1697 status = pxa2xx_spi_dma_setup(drv_data); 1698 1698 if (status) { 1699 - dev_dbg(dev, "no DMA channels available, using PIO\n"); 1699 + dev_warn(dev, "no DMA channels available, using PIO\n"); 1700 1700 platform_info->enable_dma = false; 1701 1701 } else { 1702 1702 controller->can_dma = pxa2xx_spi_can_dma;