Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info()

Our static checker found a bug where set_serial_info() uses a mutex, but
get_serial_info() does not. Fortunately, the impact of this is relatively
minor. It doesn't cause a crash or any other serious issues. However, if a
race condition occurs between set_serial_info() and get_serial_info(),
there is a chance that the data returned by get_serial_info() will be
inconsistent.

Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()")
Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>

authored by

Qiu-ji Chen and committed by
Johan Hovold
8b524944 40827729

+2
+2
drivers/usb/serial/ftdi_sio.c
··· 1443 1443 struct usb_serial_port *port = tty->driver_data; 1444 1444 struct ftdi_private *priv = usb_get_serial_port_data(port); 1445 1445 1446 + mutex_lock(&priv->cfg_lock); 1446 1447 ss->flags = priv->flags; 1447 1448 ss->baud_base = priv->baud_base; 1448 1449 ss->custom_divisor = priv->custom_divisor; 1450 + mutex_unlock(&priv->cfg_lock); 1449 1451 } 1450 1452 1451 1453 static int set_serial_info(struct tty_struct *tty, struct serial_struct *ss)