ext4: Fix possible lost inode write in no journal mode

In the no-journal case, ext4_write_inode() will fetch the bh and call
sync_dirty_buffer() on it. However, if the bh has already been
written and the bh reclaimed for some other purpose, AND if the inode
is the only one in the inode table block in use, then
ext4_get_inode_loc() will not read the inode table block from disk,
but as an optimization, fill the block with zero's assuming that its
caller will copy in the on-disk version of the inode. This is not
done by ext4_write_inode(), so the contents of the inode can simply
get lost. The fix is to use __ext4_get_inode_loc() with in_mem set to
0, instead of ext4_get_inode_loc(). Long term the API needs to be
fixed so it's obvious why latter is not safe.

Addresses-Google-Bug: #2526446

Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

authored by Curt Wohlgemuth and committed by Theodore Ts'o 8b472d73 2eaa9cfd

+1 -1
+1 -1
fs/ext4/inode.c
··· 5374 5374 } else { 5375 5375 struct ext4_iloc iloc; 5376 5376 5377 - err = ext4_get_inode_loc(inode, &iloc); 5377 + err = __ext4_get_inode_loc(inode, &iloc, 0); 5378 5378 if (err) 5379 5379 return err; 5380 5380 if (wbc->sync_mode == WB_SYNC_ALL)