Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers: media: dvb-frontends/rtl2832: fix an out-of-bounds write error

Ensure index in rtl2832_pid_filter does not exceed 31 to prevent
out-of-bounds access.

dev->filters is a 32-bit value, so set_bit and clear_bit functions should
only operate on indices from 0 to 31. If index is 32, it will attempt to
access a non-existent 33rd bit, leading to out-of-bounds access.
Change the boundary check from index > 32 to index >= 32 to resolve this
issue.

Signed-off-by: Junlin Li <make24@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 4b01e01a81b6 ("[media] rtl2832: implement PID filter")
[hverkuil: added fixes tag, rtl2830_pid_filter -> rtl2832_pid_filter in logmsg]

authored by

Junlin Li and committed by
Hans Verkuil
8ae06f36 b669f378

+1 -1
+1 -1
drivers/media/dvb-frontends/rtl2832.c
··· 983 983 index, pid, onoff, dev->slave_ts); 984 984 985 985 /* skip invalid PIDs (0x2000) */ 986 - if (pid > 0x1fff || index > 32) 986 + if (pid > 0x1fff || index >= 32) 987 987 return 0; 988 988 989 989 if (onoff)