Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: stm32mp1: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-17-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
8ad00c14 dd904848

+2 -4
+2 -4
drivers/clk/clk-stm32mp1.c
··· 2434 2434 return ret; 2435 2435 } 2436 2436 2437 - static int stm32mp1_rcc_clocks_remove(struct platform_device *pdev) 2437 + static void stm32mp1_rcc_clocks_remove(struct platform_device *pdev) 2438 2438 { 2439 2439 struct device *dev = &pdev->dev; 2440 2440 struct device_node *child, *np = dev_of_node(dev); 2441 2441 2442 2442 for_each_available_child_of_node(np, child) 2443 2443 of_clk_del_provider(child); 2444 - 2445 - return 0; 2446 2444 } 2447 2445 2448 2446 static struct platform_driver stm32mp1_rcc_clocks_driver = { ··· 2449 2451 .of_match_table = stm32mp1_match_data, 2450 2452 }, 2451 2453 .probe = stm32mp1_rcc_clocks_probe, 2452 - .remove = stm32mp1_rcc_clocks_remove, 2454 + .remove_new = stm32mp1_rcc_clocks_remove, 2453 2455 }; 2454 2456 2455 2457 static int __init stm32mp1_clocks_init(void)