Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon/lm78: Drop REALLY_SLOW_IO setting

In lm78_isa_found() there is REALLY_SLOW_IO defined around some port
accesses, probably in order to wait between multiple accesses.

Unfortunately this isn't making any difference compared to not having
this define since more than a decade, as REALLY_SLOW_IO needs to be
defined while "#include <asm/io.h>" is called to have an effect.

As there seem not to be any outstanding issues in spite of this having
no effect, just drop the "#define" and add a remark to the related
comment.

Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20251126162018.5676-3-jgross@suse.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Juergen Gross and committed by
Guenter Roeck
8ac2a19d 2f88425e

+3 -2
+3 -2
drivers/hwmon/lm78.c
··· 843 843 } 844 844 } 845 845 846 - #define REALLY_SLOW_IO 847 846 /* 848 847 * We need the timeouts for at least some LM78-like 849 848 * chips. But only if we read 'undefined' registers. 849 + * There used to be a "#define REALLY_SLOW_IO" to enforce that, but 850 + * this has been without any effect since more than a decade, so it 851 + * has been dropped. 850 852 */ 851 853 val = inb_p(address + 1); 852 854 if (inb_p(address + 2) != val 853 855 || inb_p(address + 3) != val 854 856 || inb_p(address + 7) != val) 855 857 goto release; 856 - #undef REALLY_SLOW_IO 857 858 858 859 /* 859 860 * We should be able to change the 7 LSB of the address port. The