Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vfs: increase shrinker batch size

Now that the per-sb shrinker is responsible for shrinking 2 or more
caches, increase the batch size to keep econmies of scale for
shrinking each cache. Increase the shrinker batch size to 1024
objects.

To allow for a large increase in batch size, add a conditional
reschedule to prune_icache_sb() so that we don't hold the LRU spin
lock for too long. This mirrors the behaviour of the
__shrink_dcache_sb(), and allows us to increase the batch size
without needing to worry about problems caused by long lock hold
times.

To ensure that filesystems using the per-sb shrinker callouts don't
cause problems, document that the object freeing method must
reschedule appropriately inside loops.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

authored by

Dave Chinner and committed by
Al Viro
8ab47664 0e1fdafd

+7
+6
Documentation/filesystems/vfs.txt
··· 317 317 the VM is trying to reclaim under GFP_NOFS conditions, hence this 318 318 method does not need to handle that situation itself. 319 319 320 + Implementations must include conditional reschedule calls inside any 321 + scanning loop that is done. This allows the VFS to determine 322 + appropriate scan batch sizes without having to worry about whether 323 + implementations will cause holdoff problems due to large scan batch 324 + sizes. 325 + 320 326 Whoever sets up the inode is responsible for filling in the "i_op" field. This 321 327 is a pointer to a "struct inode_operations" which describes the methods that 322 328 can be performed on individual inodes.
+1
fs/super.c
··· 182 182 183 183 s->s_shrink.seeks = DEFAULT_SEEKS; 184 184 s->s_shrink.shrink = prune_super; 185 + s->s_shrink.batch = 1024; 185 186 } 186 187 out: 187 188 return s;