Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf mips: Remove dwarf-regs.c

The file just provides the function get_arch_regstr, however, if in
the only caller get_dwarf_regstr EM_HOST is used for the EM_NONE case
the function can never be called. So remove as dead code. Tidy up the
EM_NONE cases for mips in dwarf-regs.c.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Anup Patel <anup@brainfault.org>
Cc: Yang Jihong <yangjihong@bytedance.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Shenlin Liang <liangshenlin@eswincomputing.com>
Cc: Nick Terrell <terrelln@fb.com>
Cc: Guilherme Amadio <amadio@gentoo.org>
Cc: Steinar H. Gunderson <sesse@google.com>
Cc: Changbin Du <changbin.du@huawei.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Guo Ren <guoren@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: James Clark <james.clark@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Chen Pei <cp0613@linux.alibaba.com>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Aditya Gupta <adityag@linux.ibm.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-riscv@lists.infradead.org
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Atish Patra <atishp@rivosinc.com>
Cc: Dima Kogan <dima@secretsauce.net>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Dr. David Alan Gilbert <linux@treblig.org>
Cc: linux-csky@vger.kernel.org
Link: https://lore.kernel.org/r/20241108234606.429459-13-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

authored by

Ian Rogers and committed by
Namhyung Kim
8a768a2f 1d37bd83

+3 -42
-1
tools/perf/arch/mips/util/Build
··· 1 1 perf-util-y += perf_regs.o 2 - perf-util-$(CONFIG_LIBDW) += dwarf-regs.o 3 2 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-38
tools/perf/arch/mips/util/dwarf-regs.c
··· 1 - // SPDX-License-Identifier: GPL-2.0 2 - /* 3 - * dwarf-regs.c : Mapping of DWARF debug register numbers into register names. 4 - * 5 - * Copyright (C) 2013 Cavium, Inc. 6 - * 7 - * This program is free software; you can redistribute it and/or modify 8 - * it under the terms of the GNU General Public License as published by 9 - * the Free Software Foundation; either version 2 of the License, or 10 - * (at your option) any later version. 11 - * 12 - * This program is distributed in the hope that it will be useful, 13 - * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 - * GNU General Public License for more details. 16 - * 17 - */ 18 - 19 - #include <stdio.h> 20 - #include <dwarf-regs.h> 21 - 22 - static const char *mips_gpr_names[32] = { 23 - "$0", "$1", "$2", "$3", "$4", "$5", "$6", "$7", "$8", "$9", 24 - "$10", "$11", "$12", "$13", "$14", "$15", "$16", "$17", "$18", "$19", 25 - "$20", "$21", "$22", "$23", "$24", "$25", "$26", "$27", "$28", "$29", 26 - "$30", "$31" 27 - }; 28 - 29 - const char *get_arch_regstr(unsigned int n) 30 - { 31 - if (n < 32) 32 - return mips_gpr_names[n]; 33 - if (n == 64) 34 - return "hi"; 35 - if (n == 65) 36 - return "lo"; 37 - return NULL; 38 - }
+2 -2
tools/perf/util/dwarf-regs.c
··· 32 32 const char *get_dwarf_regstr(unsigned int n, unsigned int machine, unsigned int flags) 33 33 { 34 34 #if EM_HOST == EM_X86_64 || EM_HOST == EM_386 || EM_HOST == EM_AARCH64 || EM_HOST == EM_ARM \ 35 - || EM_HOST == EM_CSKY || EM_HOST == EM_LOONGARCH 35 + || EM_HOST == EM_CSKY || EM_HOST == EM_LOONGARCH || EM_HOST == EM_MIPS 36 36 if (machine == EM_NONE) { 37 37 /* Generic arch - use host arch */ 38 38 machine = EM_HOST; ··· 40 40 #endif 41 41 switch (machine) { 42 42 #if EM_HOST != EM_X86_64 && EM_HOST != EM_386 && EM_HOST != EM_AARCH64 && EM_HOST != EM_ARM \ 43 - && EM_HOST != EM_CSKY && EM_HOST != EM_LOONGARCH 43 + && EM_HOST != EM_CSKY && EM_HOST != EM_LOONGARCH && EM_HOST != EM_MIPS 44 44 case EM_NONE: /* Generic arch - use host arch */ 45 45 return get_arch_regstr(n); 46 46 #endif
+1 -1
tools/perf/util/include/dwarf-regs.h
··· 90 90 91 91 #ifdef HAVE_LIBDW_SUPPORT 92 92 #if !defined(__x86_64__) && !defined(__i386__) && !defined(__aarch64__) && !defined(__arm__) \ 93 - && !defined(__loongarch__) 93 + && !defined(__loongarch__) && !defined(__mips__) 94 94 const char *get_arch_regstr(unsigned int n); 95 95 #endif 96 96