Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/xe2lpd: implement WA for underruns while enabling FBC

FIFO underruns are observed when FBC is enabled on plane 2 or
plane 3. Recommended WA is to update the FBC enabling sequence.
The plane binding register bits need to be updated separately
before programming the FBC enable bit.

Bspec: 74151
Reviewed-by: Mika Kahola <mika.kahola@intel.com> #v3
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231111114320.87277-2-vinod.govindapillai@intel.com

authored by

Vinod Govindapillai and committed by
Mika Kahola
8a4353d0 dd99d5b1

+7 -1
+7 -1
drivers/gpu/drm/i915/display/intel_fbc.c
··· 608 608 static void ivb_fbc_activate(struct intel_fbc *fbc) 609 609 { 610 610 struct drm_i915_private *i915 = fbc->i915; 611 + u32 dpfc_ctl; 611 612 612 613 if (DISPLAY_VER(i915) >= 10) 613 614 glk_fbc_program_cfb_stride(fbc); ··· 618 617 if (intel_gt_support_legacy_fencing(to_gt(i915))) 619 618 snb_fbc_program_fence(fbc); 620 619 620 + /* wa_14019417088 Alternative WA*/ 621 + dpfc_ctl = ivb_dpfc_ctl(fbc); 622 + if (DISPLAY_VER(i915) >= 20) 623 + intel_de_write(i915, ILK_DPFC_CONTROL(fbc->id), dpfc_ctl); 624 + 621 625 intel_de_write(i915, ILK_DPFC_CONTROL(fbc->id), 622 - DPFC_CTL_EN | ivb_dpfc_ctl(fbc)); 626 + DPFC_CTL_EN | dpfc_ctl); 623 627 } 624 628 625 629 static bool ivb_fbc_is_compressing(struct intel_fbc *fbc)