Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PNPACPI: Fix device ref leaking in acpi_pnp_match

During testing pci root bus removal, found some root bus bridge is not freed.
If booting with pnpacpi=off, those hostbridge could be freed without problem.
It turns out that some devices reference are not released during acpi_pnp_match.
that match should not hold one device ref during every calling.
Add pu_device calling before returning.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>

authored by

Yinghai Lu and committed by
Len Brown
89e96ada ac909ec3

+6 -1
+6 -1
drivers/pnp/pnpacpi/core.c
··· 321 321 { 322 322 struct acpi_device *acpi = to_acpi_device(dev); 323 323 struct pnp_dev *pnp = _pnp; 324 + struct device *physical_device; 325 + 326 + physical_device = acpi_get_physical_device(acpi->handle); 327 + if (physical_device) 328 + put_device(physical_device); 324 329 325 330 /* true means it matched */ 326 - return !acpi_get_physical_device(acpi->handle) 331 + return !physical_device 327 332 && compare_pnp_id(pnp->id, acpi_device_hid(acpi)); 328 333 } 329 334