Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memstick: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away.

The patch has been generated with the coccinelle script below.
It has been compile tested.

No memory allocation in involved in this patch, so no GFP_ tweak is needed.

@@ @@
- PCI_DMA_BIDIRECTIONAL
+ DMA_BIDIRECTIONAL

@@ @@
- PCI_DMA_TODEVICE
+ DMA_TO_DEVICE

@@ @@
- PCI_DMA_FROMDEVICE
+ DMA_FROM_DEVICE

@@ @@
- PCI_DMA_NONE
+ DMA_NONE

@@
expression e1, e2, e3;
@@
- pci_alloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3;
@@
- pci_zalloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3, e4;
@@
- pci_free_consistent(e1, e2, e3, e4)
+ dma_free_coherent(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_single(e1, e2, e3, e4)
+ dma_map_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_single(e1, e2, e3, e4)
+ dma_unmap_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4, e5;
@@
- pci_map_page(e1, e2, e3, e4, e5)
+ dma_map_page(&e1->dev, e2, e3, e4, e5)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_page(e1, e2, e3, e4)
+ dma_unmap_page(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_sg(e1, e2, e3, e4)
+ dma_map_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_sg(e1, e2, e3, e4)
+ dma_unmap_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_cpu(e1, e2, e3, e4)
+ dma_sync_single_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_device(e1, e2, e3, e4)
+ dma_sync_single_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_cpu(e1, e2, e3, e4)
+ dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_device(e1, e2, e3, e4)
+ dma_sync_sg_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2;
@@
- pci_dma_mapping_error(e1, e2)
+ dma_mapping_error(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_dma_mask(e1, e2)
+ dma_set_mask(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+ dma_set_coherent_mask(&e1->dev, e2)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/f6fe24f2372c8c627a08ace7187bfe60d35788b6.1629580314.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Christophe JAILLET and committed by
Ulf Hansson
89d74b30 2b50c81f

+8 -9
+2 -3
drivers/memstick/host/r592.c
··· 293 293 294 294 /* TODO: hidden assumption about nenth beeing always 1 */ 295 295 sg_count = dma_map_sg(&dev->pci_dev->dev, &dev->req->sg, 1, is_write ? 296 - PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); 296 + DMA_TO_DEVICE : DMA_FROM_DEVICE); 297 297 298 298 if (sg_count != 1 || sg_dma_len(&dev->req->sg) < R592_LFIFO_SIZE) { 299 299 message("problem in dma_map_sg"); ··· 310 310 } 311 311 312 312 dma_unmap_sg(&dev->pci_dev->dev, &dev->req->sg, 1, is_write ? 313 - PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); 314 - 313 + DMA_TO_DEVICE : DMA_FROM_DEVICE); 315 314 316 315 return dev->dma_error; 317 316 }
+6 -6
drivers/memstick/host/tifm_ms.c
··· 279 279 if (host->use_dma) { 280 280 if (1 != tifm_map_sg(sock, &host->req->sg, 1, 281 281 host->req->data_dir == READ 282 - ? PCI_DMA_FROMDEVICE 283 - : PCI_DMA_TODEVICE)) { 282 + ? DMA_FROM_DEVICE 283 + : DMA_TO_DEVICE)) { 284 284 host->req->error = -ENOMEM; 285 285 return host->req->error; 286 286 } ··· 350 350 if (host->use_dma) { 351 351 tifm_unmap_sg(sock, &host->req->sg, 1, 352 352 host->req->data_dir == READ 353 - ? PCI_DMA_FROMDEVICE 354 - : PCI_DMA_TODEVICE); 353 + ? DMA_FROM_DEVICE 354 + : DMA_TO_DEVICE); 355 355 } 356 356 357 357 writel((~TIFM_CTRL_LED) & readl(sock->addr + SOCK_CONTROL), ··· 607 607 if (host->use_dma) 608 608 tifm_unmap_sg(sock, &host->req->sg, 1, 609 609 host->req->data_dir == READ 610 - ? PCI_DMA_TODEVICE 611 - : PCI_DMA_FROMDEVICE); 610 + ? DMA_TO_DEVICE 611 + : DMA_FROM_DEVICE); 612 612 host->req->error = -ETIME; 613 613 614 614 do {