Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: dts: exynos: correct PMIC interrupt trigger level on Snow

The Maxim PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU. Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: c61248afa819 ("ARM: dts: Add max77686 RTC interrupt to cros5250-common")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-9-krzk@kernel.org

+1 -1
+1 -1
arch/arm/boot/dts/exynos5250-snow-common.dtsi
··· 292 292 max77686: pmic@9 { 293 293 compatible = "maxim,max77686"; 294 294 interrupt-parent = <&gpx3>; 295 - interrupts = <2 IRQ_TYPE_NONE>; 295 + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; 296 296 pinctrl-names = "default"; 297 297 pinctrl-0 = <&max77686_irq>; 298 298 wakeup-source;