Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/aspeed-scu: Replace update_bits with write_bits.

The interrupt status bits are cleared by writing 1, we should force a
write to clear the interrupt without checking if the value has changed.

Fixes: 04f605906ff0 ("irqchip: Add Aspeed SCU interrupt controller")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211124094348.11621-1-billy_tsai@aspeedtech.com
Cc: stable@vger.kernel.org

authored by

Billy Tsai and committed by
Marc Zyngier
89583896 d0a55350

+2 -2
+2 -2
drivers/irqchip/irq-aspeed-scu-ic.c
··· 76 76 generic_handle_domain_irq(scu_ic->irq_domain, 77 77 bit - scu_ic->irq_shift); 78 78 79 - regmap_update_bits(scu_ic->scu, scu_ic->reg, mask, 80 - BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT)); 79 + regmap_write_bits(scu_ic->scu, scu_ic->reg, mask, 80 + BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT)); 81 81 } 82 82 83 83 chained_irq_exit(chip, desc);