Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: Use devm_platform_ioremap_resource()

Simplify probe by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/4552ef52-f218-93b1-6dfa-668d137676f8@web.de
Link: https://lore.kernel.org/r/5ecfcf43-d6b2-1a38-dee8-b8806f30bc83@web.de
Link: https://lore.kernel.org/r/25448e11-c43f-9ae0-4c43-6f789accc026@web.de
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
Link: https://lore.kernel.org/r/8c17a59c-82ff-aa6b-5653-a38d786d3e83@web.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Markus Elfring and committed by
Alexandre Belloni
89576beb eaa6ef56

+5 -30
+1 -8
drivers/rtc/rtc-fsl-ftm-alarm.c
··· 248 248 static int ftm_rtc_probe(struct platform_device *pdev) 249 249 { 250 250 struct device_node *np = pdev->dev.of_node; 251 - struct resource *r; 252 251 int irq; 253 252 int ret; 254 253 struct ftm_rtc *rtc; ··· 264 265 if (IS_ERR(rtc->rtc_dev)) 265 266 return PTR_ERR(rtc->rtc_dev); 266 267 267 - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); 268 - if (!r) { 269 - dev_err(&pdev->dev, "cannot get resource for rtc\n"); 270 - return -ENODEV; 271 - } 272 - 273 - rtc->base = devm_ioremap_resource(&pdev->dev, r); 268 + rtc->base = devm_platform_ioremap_resource(pdev, 0); 274 269 if (IS_ERR(rtc->base)) { 275 270 dev_err(&pdev->dev, "cannot ioremap resource for rtc\n"); 276 271 return PTR_ERR(rtc->base);
+1 -7
drivers/rtc/rtc-goldfish.c
··· 165 165 static int goldfish_rtc_probe(struct platform_device *pdev) 166 166 { 167 167 struct goldfish_rtc *rtcdrv; 168 - struct resource *r; 169 168 int err; 170 169 171 170 rtcdrv = devm_kzalloc(&pdev->dev, sizeof(*rtcdrv), GFP_KERNEL); ··· 172 173 return -ENOMEM; 173 174 174 175 platform_set_drvdata(pdev, rtcdrv); 175 - 176 - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); 177 - if (!r) 178 - return -ENODEV; 179 - 180 - rtcdrv->base = devm_ioremap_resource(&pdev->dev, r); 176 + rtcdrv->base = devm_platform_ioremap_resource(pdev, 0); 181 177 if (IS_ERR(rtcdrv->base)) 182 178 return -ENODEV; 183 179
+2 -9
drivers/rtc/rtc-m48t86.c
··· 218 218 static int m48t86_rtc_probe(struct platform_device *pdev) 219 219 { 220 220 struct m48t86_rtc_info *info; 221 - struct resource *res; 222 221 unsigned char reg; 223 222 int err; 224 223 struct nvmem_config m48t86_nvmem_cfg = { ··· 234 235 if (!info) 235 236 return -ENOMEM; 236 237 237 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 238 - if (!res) 239 - return -ENODEV; 240 - info->index_reg = devm_ioremap_resource(&pdev->dev, res); 238 + info->index_reg = devm_platform_ioremap_resource(pdev, 0); 241 239 if (IS_ERR(info->index_reg)) 242 240 return PTR_ERR(info->index_reg); 243 241 244 - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); 245 - if (!res) 246 - return -ENODEV; 247 - info->data_reg = devm_ioremap_resource(&pdev->dev, res); 242 + info->data_reg = devm_platform_ioremap_resource(pdev, 1); 248 243 if (IS_ERR(info->data_reg)) 249 244 return PTR_ERR(info->data_reg); 250 245
+1 -6
drivers/rtc/rtc-r7301.c
··· 354 354 355 355 static int __init rtc7301_rtc_probe(struct platform_device *dev) 356 356 { 357 - struct resource *res; 358 357 void __iomem *regs; 359 358 struct rtc7301_priv *priv; 360 359 struct rtc_device *rtc; 361 360 int ret; 362 361 363 - res = platform_get_resource(dev, IORESOURCE_MEM, 0); 364 - if (!res) 365 - return -ENODEV; 366 - 367 362 priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL); 368 363 if (!priv) 369 364 return -ENOMEM; 370 365 371 - regs = devm_ioremap_resource(&dev->dev, res); 366 + regs = devm_platform_ioremap_resource(dev, 0); 372 367 if (IS_ERR(regs)) 373 368 return PTR_ERR(regs); 374 369