Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: change PAGEREF_RECLAIM_CLEAN with PAGE_REFRECLAIM

The local variable references in shrink_page_list is PAGEREF_RECLAIM_CLEAN
as default. It is for preventing to reclaim dirty pages when CMA try to
migrate pages. Strictly speaking, we don't need it because CMA didn't
allow to write out by .may_writepage = 0 in reclaim_clean_pages_from_list.

Moreover, it has a problem to prevent anonymous pages's swap out even
though force_reclaim = true in shrink_page_list on upcoming patch. So
this patch makes references's default value to PAGEREF_RECLAIM and rename
force_reclaim with ignore_references to make it more clear.

This is a preparatory work for next patch.

Link: http://lkml.kernel.org/r/20190726023435.214162-3-minchan@kernel.org
Signed-off-by: Minchan Kim <minchan@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Colascione <dancol@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Hillf Danton <hdanton@sina.com>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: kbuild test robot <lkp@intel.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Oleksandr Natalenko <oleksandr@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Shakeel Butt <shakeelb@google.com>
Cc: Sonny Rao <sonnyrao@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Tim Murray <timmurray@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Minchan Kim and committed by
Linus Torvalds
8940b34a 9c276cc6

+3 -3
+3 -3
mm/vmscan.c
··· 1123 1123 struct scan_control *sc, 1124 1124 enum ttu_flags ttu_flags, 1125 1125 struct reclaim_stat *stat, 1126 - bool force_reclaim) 1126 + bool ignore_references) 1127 1127 { 1128 1128 LIST_HEAD(ret_pages); 1129 1129 LIST_HEAD(free_pages); ··· 1137 1137 struct address_space *mapping; 1138 1138 struct page *page; 1139 1139 int may_enter_fs; 1140 - enum page_references references = PAGEREF_RECLAIM_CLEAN; 1140 + enum page_references references = PAGEREF_RECLAIM; 1141 1141 bool dirty, writeback; 1142 1142 unsigned int nr_pages; 1143 1143 ··· 1268 1268 } 1269 1269 } 1270 1270 1271 - if (!force_reclaim) 1271 + if (!ignore_references) 1272 1272 references = page_check_references(page, sc); 1273 1273 1274 1274 switch (references) {