power: supply: Fix null pointer dereference in smb2_probe

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

devm_kasprintf and devm_kzalloc return a pointer to dynamically
allocated memory which can be NULL upon failure.

Fixes: 8648aeb5d7b7 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Link: https://lore.kernel.org/r/20231124075021.1335289-1-chentao@kylinos.cn
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Kunwu Chan and committed by

Sebastian Reichel 2 years ago 88f04bc3 195c3167

1 changed file

expand all

drivers

power

supply

qcom_pmi8998_charger.c

drivers/power/supply/qcom_pmi8998_charger.c

··· 972 972 supply_config.of_node = pdev->dev.of_node; 973 973 974 974 desc = devm_kzalloc(chip->dev, sizeof(smb2_psy_desc), GFP_KERNEL); 975 + if (!desc) 976 + return -ENOMEM; 975 977 memcpy(desc, &smb2_psy_desc, sizeof(smb2_psy_desc)); 976 978 desc->name = 977 979 devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger", 978 980 (const char *)device_get_match_data(chip->dev)); 981 + if (!desc->name) 982 + return -ENOMEM; 979 983 980 984 chip->chg_psy = 981 985 devm_power_supply_register(chip->dev, desc, &supply_config);