Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (via-cputemp) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-19-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
88ac8226 b8753599

+2 -3
+2 -3
drivers/hwmon/via-cputemp.c
··· 182 182 return err; 183 183 } 184 184 185 - static int via_cputemp_remove(struct platform_device *pdev) 185 + static void via_cputemp_remove(struct platform_device *pdev) 186 186 { 187 187 struct via_cputemp_data *data = platform_get_drvdata(pdev); 188 188 ··· 190 190 if (data->vrm) 191 191 device_remove_file(&pdev->dev, &dev_attr_cpu0_vid); 192 192 sysfs_remove_group(&pdev->dev.kobj, &via_cputemp_group); 193 - return 0; 194 193 } 195 194 196 195 static struct platform_driver via_cputemp_driver = { ··· 197 198 .name = DRVNAME, 198 199 }, 199 200 .probe = via_cputemp_probe, 200 - .remove = via_cputemp_remove, 201 + .remove_new = via_cputemp_remove, 201 202 }; 202 203 203 204 struct pdev_entry {