Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "ax25: Fix std timer socket destroy handling."

This reverts commit 30902dc3cb0ea1cfc7ac2b17bcf478ff98420d74.

It causes all kinds of problems, based upon a report by
Bernard (f6bvp) and analysis by Jarek Poplawski.

Signed-off-by: David S. Miller <davem@davemloft.net>

+5 -3
+5 -3
net/ax25/ax25_std_timer.c
··· 39 39 40 40 switch (ax25->state) { 41 41 case AX25_STATE_0: 42 - if (!sk || 43 - sock_flag(sk, SOCK_DESTROY) || 44 - sock_flag(sk, SOCK_DEAD)) { 42 + /* Magic here: If we listen() and a new link dies before it 43 + is accepted() it isn't 'dead' so doesn't get removed. */ 44 + if (!sk || sock_flag(sk, SOCK_DESTROY) || 45 + (sk->sk_state == TCP_LISTEN && 46 + sock_flag(sk, SOCK_DEAD))) { 45 47 if (sk) { 46 48 sock_hold(sk); 47 49 ax25_destroy_socket(ax25);