[PATCH] drivers/isdn/pcbit/: possible cleanups

This patch contains the following possible cleanups:
- make some needlessly global functions static
- remove the following unused global functions:
- callbacks.c: cb_out_3
- capi.c: capi_decode_disc_conf

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by Adrian Bunk and committed by Linus Torvalds 886cca3a e3ca5e76

+8 -39
-17
drivers/isdn/pcbit/callbacks.c
··· 125 125 126 126 127 127 /* 128 - * Disconnect received (actually RELEASE COMPLETE) 129 - * This means we were not able to establish connection with remote 130 - * Inform the big boss above 131 - */ 132 - void cb_out_3(struct pcbit_dev * dev, struct pcbit_chan* chan, 133 - struct callb_data *data) 134 - { 135 - isdn_ctrl ictl; 136 - 137 - ictl.command = ISDN_STAT_DHUP; 138 - ictl.driver=dev->id; 139 - ictl.arg=chan->id; 140 - dev->dev_if->statcallb(&ictl); 141 - } 142 - 143 - 144 - /* 145 128 * Incoming call received 146 129 * inform user 147 130 */
-3
drivers/isdn/pcbit/callbacks.h
··· 19 19 extern void cb_out_2(struct pcbit_dev * dev, struct pcbit_chan* chan, 20 20 struct callb_data *data); 21 21 22 - extern void cb_out_3(struct pcbit_dev * dev, struct pcbit_chan* chan, 23 - struct callb_data *data); 24 - 25 22 extern void cb_in_1(struct pcbit_dev * dev, struct pcbit_chan* chan, 26 23 struct callb_data *data); 27 24 extern void cb_in_2(struct pcbit_dev * dev, struct pcbit_chan* chan,
-10
drivers/isdn/pcbit/capi.c
··· 627 627 return 0; 628 628 } 629 629 630 - int capi_decode_disc_conf(struct pcbit_chan *chan, struct sk_buff *skb) 631 - { 632 - ushort errcode; 633 - 634 - errcode = *((ushort*) skb->data); 635 - skb_pull(skb, 2); 636 - 637 - return errcode; 638 - } 639 - 640 630 #ifdef DEBUG 641 631 int capi_decode_debug_188(u_char *hdr, ushort hdrlen) 642 632 {
-1
drivers/isdn/pcbit/capi.h
··· 54 54 55 55 /* Connection Termination */ 56 56 extern int capi_disc_req(ushort callref, struct sk_buff **skb, u_char cause); 57 - extern int capi_decode_disc_conf(struct pcbit_chan *chan, struct sk_buff *skb); 58 57 59 58 extern int capi_decode_disc_ind(struct pcbit_chan *chan, struct sk_buff *skb); 60 59 extern int capi_disc_resp(struct pcbit_chan *chan, struct sk_buff **skb);
+8 -8
drivers/isdn/pcbit/drv.c
··· 56 56 * prototypes 57 57 */ 58 58 59 - int pcbit_command(isdn_ctrl* ctl); 60 - int pcbit_stat(u_char __user * buf, int len, int, int); 61 - int pcbit_xmit(int driver, int chan, int ack, struct sk_buff *skb); 62 - int pcbit_writecmd(const u_char __user *, int, int, int); 59 + static int pcbit_command(isdn_ctrl* ctl); 60 + static int pcbit_stat(u_char __user * buf, int len, int, int); 61 + static int pcbit_xmit(int driver, int chan, int ack, struct sk_buff *skb); 62 + static int pcbit_writecmd(const u_char __user *, int, int, int); 63 63 64 64 static int set_protocol_running(struct pcbit_dev * dev); 65 65 ··· 238 238 } 239 239 #endif 240 240 241 - int pcbit_command(isdn_ctrl* ctl) 241 + static int pcbit_command(isdn_ctrl* ctl) 242 242 { 243 243 struct pcbit_dev *dev; 244 244 struct pcbit_chan *chan; ··· 330 330 } 331 331 #endif 332 332 333 - int pcbit_xmit(int driver, int chnum, int ack, struct sk_buff *skb) 333 + static int pcbit_xmit(int driver, int chnum, int ack, struct sk_buff *skb) 334 334 { 335 335 ushort hdrlen; 336 336 int refnum, len; ··· 389 389 return len; 390 390 } 391 391 392 - int pcbit_writecmd(const u_char __user *buf, int len, int driver, int channel) 392 + static int pcbit_writecmd(const u_char __user *buf, int len, int driver, int channel) 393 393 { 394 394 struct pcbit_dev * dev; 395 395 int i, j; ··· 713 713 static int stat_st = 0; 714 714 static int stat_end = 0; 715 715 716 - int pcbit_stat(u_char __user *buf, int len, int driver, int channel) 716 + static int pcbit_stat(u_char __user *buf, int len, int driver, int channel) 717 717 { 718 718 int stat_count; 719 719 stat_count = stat_end - stat_st;