Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: backlight: mp3309c: Remove two required properties

The two properties:

- max-brightness
- default brightness

are not really required, so they can be removed from the "required"
section.
The "max-brightness" is no longer used in the current version
of the driver (it was used only in the first version).
The "default-brightness", if omitted in the DT, is managed by the
device driver, using a default value. This value depends on the dimming
mode used:

- for the "analog mode", via I2C commands, this value is fixed by
hardware (=31)
- while in case of pwm mode the default used is the last value of the
brightness-levels array.

Also the brightness-levels array is not required:

- in "analog mode", via I2C commands, the brightness-level array is
fixed by hardware (0..31).;
- in pwm dimming mode, the driver uses a default array of 0..255 and
the "default-brightness" is the last one, which is "255"

NOTE: there are no compatibility problems with the previous version,
since the device driver has not yet been included in any kernel.
Only this dt-binding yaml file is already included in the current
v6.7.0-rc1 kernel version.
No developer may have used it.

Other changes:

- improve the backlight working mode description, in the "description"
section
- update the example, removing the "max-brightness" and introducing the
"brightess-levels" property

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20231116105319.957600-2-f.suligoi@asem.it
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Flavio Suligoi and committed by
Lee Jones
87f33a1b b85ea95d

+4 -6
+4 -6
Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
··· 14 14 programmable switching frequency to optimize efficiency. 15 15 It supports two different dimming modes: 16 16 17 - - analog mode, via I2C commands (default) 18 - - PWM controlled mode. 17 + - analog mode, via I2C commands, as default mode (32 dimming levels) 18 + - PWM controlled mode (optional) 19 19 20 20 The datasheet is available at: 21 21 https://www.monolithicpower.com/en/mp3309c.html ··· 50 50 required: 51 51 - compatible 52 52 - reg 53 - - max-brightness 54 - - default-brightness 55 53 56 54 unevaluatedProperties: false 57 55 ··· 64 66 compatible = "mps,mp3309c"; 65 67 reg = <0x17>; 66 68 pwms = <&pwm1 0 3333333 0>; /* 300 Hz --> (1/f) * 1*10^9 */ 67 - max-brightness = <100>; 68 - default-brightness = <80>; 69 + brightness-levels = <0 4 8 16 32 64 128 255>; 70 + default-brightness = <6>; 69 71 mps,overvoltage-protection-microvolt = <24000000>; 70 72 }; 71 73 };