Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fb: via: turn gpiolib and i2c selects into dependencies

Device driver should not directly select subsystems. In this case
we get build warnings like

warning: (ARCH_REQUIRE_GPIOLIB && PINCTRL_AT91 && PINCTRL_NOMADIK && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)

which we can avoid using the normal 'depends on' statement.

Also, this patch makes it possible for DRM drivers to have a dependency
on GPIOLIB without getting circular Kconfig dependencies.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

authored by

Arnd Bergmann and committed by
Tomi Valkeinen
87f0fce7 5b72ae9a

+1 -3
+1 -3
drivers/video/fbdev/Kconfig
··· 1530 1530 1531 1531 config FB_VIA 1532 1532 tristate "VIA UniChrome (Pro) and Chrome9 display support" 1533 - depends on FB && PCI && X86 1533 + depends on FB && PCI && X86 && GPIOLIB && I2C 1534 1534 select FB_CFB_FILLRECT 1535 1535 select FB_CFB_COPYAREA 1536 1536 select FB_CFB_IMAGEBLIT 1537 1537 select I2C_ALGOBIT 1538 - select I2C 1539 - select GPIOLIB 1540 1538 help 1541 1539 This is the frame buffer device driver for Graphics chips of VIA 1542 1540 UniChrome (Pro) Family (CLE266,PM800/CN400,P4M800CE/P4M800Pro/