Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: arm-charlcd: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jingoo Han and committed by
Greg Kroah-Hartman
87f0a427 21b066f1

+1 -4
+1 -4
drivers/misc/arm-charlcd.c
··· 291 291 lcd->virtbase = ioremap(lcd->phybase, lcd->physize); 292 292 if (!lcd->virtbase) { 293 293 ret = -ENOMEM; 294 - goto out_no_remap; 294 + goto out_no_memregion; 295 295 } 296 296 297 297 lcd->irq = platform_get_irq(pdev, 0); ··· 320 320 321 321 out_no_irq: 322 322 iounmap(lcd->virtbase); 323 - out_no_remap: 324 - platform_set_drvdata(pdev, NULL); 325 323 out_no_memregion: 326 324 release_mem_region(lcd->phybase, SZ_4K); 327 325 out_no_resource: ··· 335 337 free_irq(lcd->irq, lcd); 336 338 iounmap(lcd->virtbase); 337 339 release_mem_region(lcd->phybase, lcd->physize); 338 - platform_set_drvdata(pdev, NULL); 339 340 kfree(lcd); 340 341 } 341 342