Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto

Artem Savkov reported that commit 5efec5c655dd leads to a packet loss under
IPSec configuration. It appears that his setup consists of a TUN device,
which does not have a MAC header.

Make sure MAC header exists.

Note: TUN device sets a MAC header pointer, although it does not have one.

Fixes: 5efec5c655dd ("xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version")
Reported-by: Artem Savkov <artem.savkov@gmail.com>
Tested-by: Artem Savkov <artem.savkov@gmail.com>
Signed-off-by: Yossi Kuperman <yossiku@mellanox.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

authored by

Yossi Kuperman and committed by
Steffen Klassert
87cdf314 b8b549ee

+4 -2
+2 -1
net/ipv4/xfrm4_mode_tunnel.c
··· 92 92 93 93 skb_reset_network_header(skb); 94 94 skb_mac_header_rebuild(skb); 95 - eth_hdr(skb)->h_proto = skb->protocol; 95 + if (skb->mac_len) 96 + eth_hdr(skb)->h_proto = skb->protocol; 96 97 97 98 err = 0; 98 99
+2 -1
net/ipv6/xfrm6_mode_tunnel.c
··· 92 92 93 93 skb_reset_network_header(skb); 94 94 skb_mac_header_rebuild(skb); 95 - eth_hdr(skb)->h_proto = skb->protocol; 95 + if (skb->mac_len) 96 + eth_hdr(skb)->h_proto = skb->protocol; 96 97 97 98 err = 0; 98 99