Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Bluetooth: h5: Do not initialize Configuration field

Initializing Configuration field in H5 Config message to 0x01 gives
wrong impression that the value is used and needed. Later on the whole
field is rewritten with h5_cfg_field().

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

authored by

Andrei Emeltchenko and committed by
Marcel Holtmann
87a6b9bd c3838353

+2 -2
+2 -2
drivers/bluetooth/hci_h5.c
··· 123 123 static void h5_timed_event(unsigned long arg) 124 124 { 125 125 const unsigned char sync_req[] = { 0x01, 0x7e }; 126 - unsigned char conf_req[] = { 0x03, 0xfc, 0x01 }; 126 + unsigned char conf_req[3] = { 0x03, 0xfc }; 127 127 struct hci_uart *hu = (struct hci_uart *)arg; 128 128 struct h5 *h5 = hu->priv; 129 129 struct sk_buff *skb; ··· 281 281 struct h5 *h5 = hu->priv; 282 282 const unsigned char sync_req[] = { 0x01, 0x7e }; 283 283 const unsigned char sync_rsp[] = { 0x02, 0x7d }; 284 - unsigned char conf_req[] = { 0x03, 0xfc, 0x01 }; 284 + unsigned char conf_req[3] = { 0x03, 0xfc }; 285 285 const unsigned char conf_rsp[] = { 0x04, 0x7b }; 286 286 const unsigned char wakeup_req[] = { 0x05, 0xfa }; 287 287 const unsigned char woken_req[] = { 0x06, 0xf9 };