Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge branch 'bnx2x-fixes'

Yuval Mintz says:

====================
bnx2x: small fixes

This adds 2 small fixes, one to error flows during memory release
and the other to flash writes via ethtool API.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

+17 -1
+1 -1
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
··· 262 262 if (likely(skb)) { 263 263 (*pkts_compl)++; 264 264 (*bytes_compl) += skb->len; 265 + dev_kfree_skb_any(skb); 265 266 } 266 267 267 - dev_kfree_skb_any(skb); 268 268 tx_buf->first_bd = 0; 269 269 tx_buf->skb = NULL; 270 270
+16
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
··· 1718 1718 offset += sizeof(u32); 1719 1719 data_buf += sizeof(u32); 1720 1720 written_so_far += sizeof(u32); 1721 + 1722 + /* At end of each 4Kb page, release nvram lock to allow MFW 1723 + * chance to take it for its own use. 1724 + */ 1725 + if ((cmd_flags & MCPR_NVM_COMMAND_LAST) && 1726 + (written_so_far < buf_size)) { 1727 + DP(BNX2X_MSG_ETHTOOL | BNX2X_MSG_NVM, 1728 + "Releasing NVM lock after offset 0x%x\n", 1729 + (u32)(offset - sizeof(u32))); 1730 + bnx2x_release_nvram_lock(bp); 1731 + usleep_range(1000, 2000); 1732 + rc = bnx2x_acquire_nvram_lock(bp); 1733 + if (rc) 1734 + return rc; 1735 + } 1736 + 1721 1737 cmd_flags = 0; 1722 1738 } 1723 1739