tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

NFC: pn533: Fix ACR122 related debug output

Instead of dumping ACR122 frames as errors, we use the print_hex_dump()
dynamic debug APIs.
We also print an accurate IC version, as the ACR122 is pn532 based.

Signed-off-by: Olivier Guiter <olivier.guiter@linux.intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

authored by

Olivier Guiter and committed by
Samuel Ortiz 86eca4e7 be085653

+4 -4
+4 -4
drivers/nfc/pn533.c
··· 2501 2501 2502 2502 nfc_dev_dbg(&urb->dev->dev, "%s", __func__); 2503 2503 2504 - print_hex_dump(KERN_ERR, "ACR122 RX: ", DUMP_PREFIX_NONE, 16, 1, 2504 + print_hex_dump_debug("ACR122 RX: ", DUMP_PREFIX_NONE, 16, 1, 2505 2505 urb->transfer_buffer, urb->transfer_buffer_length, 2506 2506 false); 2507 2507 ··· 2532 2532 dev->out_urb->transfer_buffer = cmd; 2533 2533 dev->out_urb->transfer_buffer_length = sizeof(cmd); 2534 2534 2535 - print_hex_dump(KERN_ERR, "ACR122 TX: ", DUMP_PREFIX_NONE, 16, 1, 2535 + print_hex_dump_debug("ACR122 TX: ", DUMP_PREFIX_NONE, 16, 1, 2536 2536 cmd, sizeof(cmd), false); 2537 2537 2538 2538 rc = usb_submit_urb(dev->out_urb, GFP_KERNEL); ··· 2786 2786 goto destroy_wq; 2787 2787 2788 2788 nfc_dev_info(&dev->interface->dev, 2789 - "NXP PN533 firmware ver %d.%d now attached", 2790 - fw_ver.ver, fw_ver.rev); 2789 + "NXP PN5%02X firmware ver %d.%d now attached", 2790 + fw_ver.ic, fw_ver.ver, fw_ver.rev); 2791 2791 2792 2792 2793 2793 dev->nfc_dev = nfc_allocate_device(&pn533_nfc_ops, protocols,