Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

There are several places where descriptors are freed using identical code.
This patch puts this code into a function to reduce code duplication.

Signed-off-by: Hongbo Zhang <hongbo.zhang@freescale.com>
Signed-off-by: Qiang Liu <qiang.liu@freescale.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

authored by

Hongbo Zhang and committed by
Vinod Koul
86d19a54 867dfa5d

+17 -10
+17 -10
drivers/dma/fsldma.c
··· 418 418 } 419 419 420 420 /** 421 + * fsl_dma_free_descriptor - Free descriptor from channel's DMA pool. 422 + * @chan : Freescale DMA channel 423 + * @desc: descriptor to be freed 424 + */ 425 + static void fsl_dma_free_descriptor(struct fsldma_chan *chan, 426 + struct fsl_desc_sw *desc) 427 + { 428 + list_del(&desc->node); 429 + chan_dbg(chan, "LD %p free\n", desc); 430 + dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); 431 + } 432 + 433 + /** 421 434 * fsl_dma_alloc_descriptor - Allocate descriptor from channel's DMA pool. 422 435 * @chan : Freescale DMA channel 423 436 * ··· 502 489 { 503 490 struct fsl_desc_sw *desc, *_desc; 504 491 505 - list_for_each_entry_safe(desc, _desc, list, node) { 506 - list_del(&desc->node); 507 - chan_dbg(chan, "LD %p free\n", desc); 508 - dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); 509 - } 492 + list_for_each_entry_safe(desc, _desc, list, node) 493 + fsl_dma_free_descriptor(chan, desc); 510 494 } 511 495 512 496 static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan, ··· 511 501 { 512 502 struct fsl_desc_sw *desc, *_desc; 513 503 514 - list_for_each_entry_safe_reverse(desc, _desc, list, node) { 515 - list_del(&desc->node); 516 - chan_dbg(chan, "LD %p free\n", desc); 517 - dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys); 518 - } 504 + list_for_each_entry_safe_reverse(desc, _desc, list, node) 505 + fsl_dma_free_descriptor(chan, desc); 519 506 } 520 507 521 508 /**