Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

block/drbd: Combine two drbd_submit_peer_request() arguments

Combine the drbd_submit_peer_request() 'op' and 'op_flags' arguments
into a single argument. This patch does not change any functionality.

Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-15-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Bart Van Assche and committed by
Jens Axboe
86563de8 9945172a

+9 -11
+1 -2
drivers/block/drbd/drbd_int.h
··· 1547 1547 extern bool drbd_rs_should_slow_down(struct drbd_device *device, sector_t sector, 1548 1548 bool throttle_if_app_is_waiting); 1549 1549 extern int drbd_submit_peer_request(struct drbd_device *, 1550 - struct drbd_peer_request *, enum req_op, 1551 - blk_opf_t, int); 1550 + struct drbd_peer_request *, blk_opf_t, int); 1552 1551 extern int drbd_free_peer_reqs(struct drbd_device *, struct list_head *); 1553 1552 extern struct drbd_peer_request *drbd_alloc_peer_req(struct drbd_peer_device *, u64, 1554 1553 sector_t, unsigned int,
+7 -8
drivers/block/drbd/drbd_receiver.c
··· 1621 1621 /* TODO allocate from our own bio_set. */ 1622 1622 int drbd_submit_peer_request(struct drbd_device *device, 1623 1623 struct drbd_peer_request *peer_req, 1624 - const enum req_op op, const blk_opf_t op_flags, 1625 - const int fault_type) 1624 + const blk_opf_t opf, const int fault_type) 1626 1625 { 1627 1626 struct bio *bios = NULL; 1628 1627 struct bio *bio; ··· 1667 1668 * generated bio, but a bio allocated on behalf of the peer. 1668 1669 */ 1669 1670 next_bio: 1670 - bio = bio_alloc(device->ldev->backing_bdev, nr_pages, op | op_flags, 1671 - GFP_NOIO); 1671 + bio = bio_alloc(device->ldev->backing_bdev, nr_pages, opf, GFP_NOIO); 1672 1672 /* > peer_req->i.sector, unless this is the first bio */ 1673 1673 bio->bi_iter.bi_sector = sector; 1674 1674 bio->bi_private = peer_req; ··· 2058 2060 spin_unlock_irq(&device->resource->req_lock); 2059 2061 2060 2062 atomic_add(pi->size >> 9, &device->rs_sect_ev); 2061 - if (drbd_submit_peer_request(device, peer_req, REQ_OP_WRITE, 0, 2063 + if (drbd_submit_peer_request(device, peer_req, REQ_OP_WRITE, 2062 2064 DRBD_FAULT_RS_WR) == 0) 2063 2065 return 0; 2064 2066 ··· 2680 2682 peer_req->flags |= EE_CALL_AL_COMPLETE_IO; 2681 2683 } 2682 2684 2683 - err = drbd_submit_peer_request(device, peer_req, op, op_flags, 2685 + err = drbd_submit_peer_request(device, peer_req, op | op_flags, 2684 2686 DRBD_FAULT_DT_WR); 2685 2687 if (!err) 2686 2688 return 0; ··· 2978 2980 submit: 2979 2981 update_receiver_timing_details(connection, drbd_submit_peer_request); 2980 2982 inc_unacked(device); 2981 - if (drbd_submit_peer_request(device, peer_req, REQ_OP_READ, 0, 2983 + if (drbd_submit_peer_request(device, peer_req, REQ_OP_READ, 2982 2984 fault_type) == 0) 2983 2985 return 0; 2984 2986 ··· 4968 4970 spin_unlock_irq(&device->resource->req_lock); 4969 4971 4970 4972 atomic_add(pi->size >> 9, &device->rs_sect_ev); 4971 - err = drbd_submit_peer_request(device, peer_req, op, 0, DRBD_FAULT_RS_WR); 4973 + err = drbd_submit_peer_request(device, peer_req, op, 4974 + DRBD_FAULT_RS_WR); 4972 4975 4973 4976 if (err) { 4974 4977 spin_lock_irq(&device->resource->req_lock);
+1 -1
drivers/block/drbd/drbd_worker.c
··· 405 405 spin_unlock_irq(&device->resource->req_lock); 406 406 407 407 atomic_add(size >> 9, &device->rs_sect_ev); 408 - if (drbd_submit_peer_request(device, peer_req, REQ_OP_READ, 0, 408 + if (drbd_submit_peer_request(device, peer_req, REQ_OP_READ, 409 409 DRBD_FAULT_RS_RD) == 0) 410 410 return 0; 411 411