Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf parse-events: Support event alias in form foo-bar-baz

Event aliasing for events whose name in the form foo-bar-baz is not
supported, while foo-bar, foo_bar_baz, and other combinations are, i.e.
two hyphens are not supported.

The HiSilicon D06 platform has events in such form:

$ ./perf list sdir-home-migrate

List of pre-defined events (to be used in -e):

uncore hha:
sdir-home-migrate
[Unit: hisi_sccl,hha]

$ sudo ./perf stat -e sdir-home-migrate
event syntax error: 'sdir-home-migrate'
\___ parser error
Run 'perf list' for a list of valid events

Usage: perf stat [<options>] [<command>]

-e, --event <event>event selector. use 'perf list' to list available events

To support, add an extra PMU event symbol type for "baz", and add a new
rule in the bison file.

Signed-off-by: John Garry <john.garry@huawei.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qi Liu <liuqi115@huawei.com>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linuxarm@huawei.com
Link: https://lore.kernel.org/r/1642432215-234089-2-git-send-email-john.garry@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

John Garry and committed by
Arnaldo Carvalho de Melo
864bc8c9 3606c0e1

+41 -4
+23 -2
tools/perf/util/parse-events.c
··· 2098 2098 pmu = NULL; 2099 2099 while ((pmu = perf_pmu__scan(pmu)) != NULL) { 2100 2100 list_for_each_entry(alias, &pmu->aliases, list) { 2101 - if (strchr(alias->name, '-')) 2101 + char *tmp = strchr(alias->name, '-'); 2102 + 2103 + if (tmp) { 2104 + char *tmp2 = NULL; 2105 + 2106 + tmp2 = strchr(tmp + 1, '-'); 2102 2107 len++; 2108 + if (tmp2) 2109 + len++; 2110 + } 2111 + 2103 2112 len++; 2104 2113 } 2105 2114 } ··· 2128 2119 list_for_each_entry(alias, &pmu->aliases, list) { 2129 2120 struct perf_pmu_event_symbol *p = perf_pmu_events_list + len; 2130 2121 char *tmp = strchr(alias->name, '-'); 2122 + char *tmp2 = NULL; 2131 2123 2132 - if (tmp != NULL) { 2124 + if (tmp) 2125 + tmp2 = strchr(tmp + 1, '-'); 2126 + if (tmp2) { 2127 + SET_SYMBOL(strndup(alias->name, tmp - alias->name), 2128 + PMU_EVENT_SYMBOL_PREFIX); 2129 + p++; 2130 + tmp++; 2131 + SET_SYMBOL(strndup(tmp, tmp2 - tmp), PMU_EVENT_SYMBOL_SUFFIX); 2132 + p++; 2133 + SET_SYMBOL(strdup(++tmp2), PMU_EVENT_SYMBOL_SUFFIX2); 2134 + len += 3; 2135 + } else if (tmp) { 2133 2136 SET_SYMBOL(strndup(alias->name, tmp - alias->name), 2134 2137 PMU_EVENT_SYMBOL_PREFIX); 2135 2138 p++;
+1
tools/perf/util/parse-events.h
··· 53 53 PMU_EVENT_SYMBOL, /* normal style PMU event */ 54 54 PMU_EVENT_SYMBOL_PREFIX, /* prefix of pre-suf style event */ 55 55 PMU_EVENT_SYMBOL_SUFFIX, /* suffix of pre-suf style event */ 56 + PMU_EVENT_SYMBOL_SUFFIX2, /* suffix of pre-suf2 style event */ 56 57 }; 57 58 58 59 struct perf_pmu_event_symbol {
+2
tools/perf/util/parse-events.l
··· 149 149 return PE_PMU_EVENT_PRE; 150 150 case PMU_EVENT_SYMBOL_SUFFIX: 151 151 return PE_PMU_EVENT_SUF; 152 + case PMU_EVENT_SYMBOL_SUFFIX2: 153 + return PE_PMU_EVENT_SUF2; 152 154 case PMU_EVENT_SYMBOL: 153 155 return parse_state->fake_pmu 154 156 ? PE_PMU_EVENT_FAKE : PE_KERNEL_PMU_EVENT;
+15 -2
tools/perf/util/parse-events.y
··· 69 69 %token PE_NAME_CACHE_TYPE PE_NAME_CACHE_OP_RESULT 70 70 %token PE_PREFIX_MEM PE_PREFIX_RAW PE_PREFIX_GROUP 71 71 %token PE_ERROR 72 - %token PE_PMU_EVENT_PRE PE_PMU_EVENT_SUF PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE 72 + %token PE_PMU_EVENT_PRE PE_PMU_EVENT_SUF PE_PMU_EVENT_SUF2 PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE 73 73 %token PE_ARRAY_ALL PE_ARRAY_RANGE 74 74 %token PE_DRV_CFG_TERM 75 75 %type <num> PE_VALUE ··· 87 87 %type <str> PE_MODIFIER_EVENT 88 88 %type <str> PE_MODIFIER_BP 89 89 %type <str> PE_EVENT_NAME 90 - %type <str> PE_PMU_EVENT_PRE PE_PMU_EVENT_SUF PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE 90 + %type <str> PE_PMU_EVENT_PRE PE_PMU_EVENT_SUF PE_PMU_EVENT_SUF2 PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE 91 91 %type <str> PE_DRV_CFG_TERM 92 92 %type <str> event_pmu_name 93 93 %destructor { free ($$); } <str> ··· 368 368 err = parse_events_multi_pmu_add(_parse_state, $1, $2, &list); 369 369 free($1); 370 370 if (err < 0) 371 + YYABORT; 372 + $$ = list; 373 + } 374 + | 375 + PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF '-' PE_PMU_EVENT_SUF2 sep_dc 376 + { 377 + struct list_head *list; 378 + char pmu_name[128]; 379 + snprintf(pmu_name, sizeof(pmu_name), "%s-%s-%s", $1, $3, $5); 380 + free($1); 381 + free($3); 382 + free($5); 383 + if (parse_events_multi_pmu_add(_parse_state, pmu_name, NULL, &list) < 0) 371 384 YYABORT; 372 385 $$ = list; 373 386 }