Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Kill DRM_*MEMORYBARRIER

The real linux interfaces are soooo much easier on the eyes ...

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>

authored by

Daniel Vetter and committed by
Dave Airlie
85b2331b 1d6ac185

+14 -21
+1 -1
drivers/gpu/drm/gma500/psb_irq.c
··· 253 253 254 254 PSB_WVDC32(vdc_stat, PSB_INT_IDENTITY_R); 255 255 (void) PSB_RVDC32(PSB_INT_IDENTITY_R); 256 - DRM_READMEMORYBARRIER(); 256 + rmb(); 257 257 258 258 if (!handled) 259 259 return IRQ_NONE;
+1 -1
drivers/gpu/drm/mga/mga_drv.h
··· 193 193 extern long mga_compat_ioctl(struct file *filp, unsigned int cmd, 194 194 unsigned long arg); 195 195 196 - #define mga_flush_write_combine() DRM_WRITEMEMORYBARRIER() 196 + #define mga_flush_write_combine() wmb() 197 197 198 198 #define MGA_READ8(reg) DRM_READ8(dev_priv->mmio, (reg)) 199 199 #define MGA_READ(reg) DRM_READ32(dev_priv->mmio, (reg))
+1 -1
drivers/gpu/drm/nouveau/nouveau_dma.c
··· 100 100 101 101 chan->dma.ib_put = (chan->dma.ib_put + 1) & chan->dma.ib_max; 102 102 103 - DRM_MEMORYBARRIER(); 103 + mb(); 104 104 /* Flush writes. */ 105 105 nouveau_bo_rd32(pb, 0); 106 106
+1 -1
drivers/gpu/drm/nouveau/nouveau_dma.h
··· 155 155 } 156 156 157 157 #define WRITE_PUT(val) do { \ 158 - DRM_MEMORYBARRIER(); \ 158 + mb(); \ 159 159 nouveau_bo_rd32(chan->push.buffer, 0); \ 160 160 nv_wo32(chan->object, chan->user_put, ((val) << 2) + chan->push.vma.offset); \ 161 161 } while (0)
+1 -1
drivers/gpu/drm/r128/r128_drv.h
··· 514 514 if (R128_VERBOSE) \ 515 515 DRM_INFO("COMMIT_RING() tail=0x%06x\n", \ 516 516 dev_priv->ring.tail); \ 517 - DRM_MEMORYBARRIER(); \ 517 + mb(); \ 518 518 R128_WRITE(R128_PM4_BUFFER_DL_WPTR, dev_priv->ring.tail); \ 519 519 R128_READ(R128_PM4_BUFFER_DL_WPTR); \ 520 520 } while (0)
+1 -1
drivers/gpu/drm/radeon/radeon_cp.c
··· 2228 2228 2229 2229 dev_priv->ring.tail &= dev_priv->ring.tail_mask; 2230 2230 2231 - DRM_MEMORYBARRIER(); 2231 + mb(); 2232 2232 GET_RING_HEAD( dev_priv ); 2233 2233 2234 2234 if ((dev_priv->flags & RADEON_FAMILY_MASK) >= CHIP_R600) {
+1 -1
drivers/gpu/drm/radeon/radeon_ring.c
··· 463 463 while (ring->wptr & ring->align_mask) { 464 464 radeon_ring_write(ring, ring->nop); 465 465 } 466 - DRM_MEMORYBARRIER(); 466 + mb(); 467 467 radeon_ring_set_wptr(rdev, ring); 468 468 } 469 469
+3 -3
drivers/gpu/drm/savage/savage_bci.c
··· 49 49 #endif 50 50 51 51 for (i = 0; i < SAVAGE_DEFAULT_USEC_TIMEOUT; i++) { 52 - DRM_MEMORYBARRIER(); 52 + mb(); 53 53 status = dev_priv->status_ptr[0]; 54 54 if ((status & mask) < threshold) 55 55 return 0; ··· 123 123 int i; 124 124 125 125 for (i = 0; i < SAVAGE_EVENT_USEC_TIMEOUT; i++) { 126 - DRM_MEMORYBARRIER(); 126 + mb(); 127 127 status = dev_priv->status_ptr[1]; 128 128 if ((((status & 0xffff) - e) & 0xffff) <= 0x7fff || 129 129 (status & 0xffff) == 0) ··· 449 449 } 450 450 } 451 451 452 - DRM_MEMORYBARRIER(); 452 + mb(); 453 453 454 454 /* do flush ... */ 455 455 phys_addr = dev_priv->cmd_dma->offset +
+1 -1
drivers/gpu/drm/savage/savage_state.c
··· 1032 1032 1033 1033 /* Make sure writes to DMA buffers are finished before sending 1034 1034 * DMA commands to the graphics hardware. */ 1035 - DRM_MEMORYBARRIER(); 1035 + mb(); 1036 1036 1037 1037 /* Coming from user space. Don't know if the Xserver has 1038 1038 * emitted wait commands. Assuming the worst. */
+2 -2
drivers/gpu/drm/via/via_dma.c
··· 60 60 dev_priv->dma_low += 8; \ 61 61 } 62 62 63 - #define via_flush_write_combine() DRM_MEMORYBARRIER() 63 + #define via_flush_write_combine() mb() 64 64 65 65 #define VIA_OUT_RING_QW(w1, w2) do { \ 66 66 *vb++ = (w1); \ ··· 543 543 544 544 VIA_WRITE(VIA_REG_TRANSPACE, pause_addr_hi); 545 545 VIA_WRITE(VIA_REG_TRANSPACE, pause_addr_lo); 546 - DRM_WRITEMEMORYBARRIER(); 546 + wmb(); 547 547 VIA_WRITE(VIA_REG_TRANSPACE, command | HC_HAGPCMNT_MASK); 548 548 VIA_READ(VIA_REG_TRANSPACE); 549 549
+1 -1
drivers/gpu/drm/via/via_dmablit.c
··· 217 217 VIA_WRITE(VIA_PCI_DMA_MR0 + engine*0x04, VIA_DMA_MR_CM | VIA_DMA_MR_TDIE); 218 218 VIA_WRITE(VIA_PCI_DMA_BCR0 + engine*0x10, 0); 219 219 VIA_WRITE(VIA_PCI_DMA_DPR0 + engine*0x10, vsg->chain_start); 220 - DRM_WRITEMEMORYBARRIER(); 220 + wmb(); 221 221 VIA_WRITE(VIA_PCI_DMA_CSR0 + engine*0x04, VIA_DMA_CSR_DE | VIA_DMA_CSR_TS); 222 222 VIA_READ(VIA_PCI_DMA_CSR0 + engine*0x04); 223 223 }
-7
include/drm/drm_os_linux.h
··· 35 35 #define DRM_WRITE16(map, offset, val) writew(val, ((void __iomem *)(map)->handle) + (offset)) 36 36 /** Write a dword into a MMIO region */ 37 37 #define DRM_WRITE32(map, offset, val) writel(val, ((void __iomem *)(map)->handle) + (offset)) 38 - /** Read memory barrier */ 39 38 40 39 /** Read a qword from a MMIO region - be careful using these unless you really understand them */ 41 40 #define DRM_READ64(map, offset) readq(((void __iomem *)(map)->handle) + (offset)) 42 41 /** Write a qword into a MMIO region */ 43 42 #define DRM_WRITE64(map, offset, val) writeq(val, ((void __iomem *)(map)->handle) + (offset)) 44 - 45 - #define DRM_READMEMORYBARRIER() rmb() 46 - /** Write memory barrier */ 47 - #define DRM_WRITEMEMORYBARRIER() wmb() 48 - /** Read/write memory barrier */ 49 - #define DRM_MEMORYBARRIER() mb() 50 43 51 44 #define DRM_WAIT_ON( ret, queue, timeout, condition ) \ 52 45 do { \